Revert "Fix errors during envtest teardown" #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`make test` is leaking the kube-apiserver and etcd processes. When unoticed, this causes `make test` to fail with weird errors like failing to open a file because of rlimit. Investigation leads to commit 053f866 which was added to work around the very same problems at the time according to Pradipta. Reverting this commit fixes the issue. It seems that updates to the controller-runtime and deps might have changed something and we no longer need the workaround. Let's just revert 053f866. Fixes https://issues.redhat.com/browse/KATA-2168 Signed-off-by: Greg Kurz <groug@kaod.org>
pmores
approved these changes
May 15, 2023
Closed
gkurz
added a commit
to gkurz/sandboxed-containers-operator
that referenced
this pull request
May 17, 2023
PR openshift#307 was too optimistic. The original issue worked around by 053f866 still exists actually ; `make test` is now failing with : [FAILED] Unexpected error: <errors.aggregate | len:1, cap:1>: [ <*errors.errorString | 0xc0005ebf80>{ s: "timeout waiting for process kube-apiserver to stop", }, ] timeout waiting for process kube-apiserver to stop occurred This is caused by a missing cancellation of the certwatcher in the controller-runtime. The fix, as documented in [1], is to create a cancellable context, pass it to envtest and cancel it just before tearing down the test. [1] kubernetes-sigs/kubebuilder#2379 Signed-off-by: Greg Kurz <groug@kaod.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make testis leaking the kube-apiserver and etcd processes. When unoticed, this causesmake testto fail with weird errors like failing to open a file because of rlimit.Investigation leads to commit 053f866 which was added to work around the very same problems at the time according to Pradipta. Reverting this commit fixes the issue.
It seems that updates to the controller-runtime and deps might have changed something and we no longer need the workaround.
Let's just revert 053f866.
Fixes https://issues.redhat.com/browse/KATA-2168
- Description of the problem which is fixed/What is the use case
- What I did
- How to verify it
- Description for the changelog