Fast-forward devel to peer-pods-tech-preview #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebase peer pods on devel
This fixes an omission in PR openshift#300 where the special case of KataConfig deletion while there are no kata nodes on a cluster wasn't handled properly and uninstallation got stuck. This happened because the uninstallation flow assumed incorrectly that it will always be necessary for the MCO to reconciliate which is not the case. Installation flow (PR openshift#291) got this right and while the idea of PR openshift#300 was basically to make uninstallation flow analogous to installation, this aspect was omitted by mistake. Signed-off-by: Pavel Mores <pmores@redhat.com>
…when-no-kata-nodes Fix kataconfig deletion when no kata nodes are on cluster
gkurz
approved these changes
May 17, 2023
|
@pmores BTW do we need to do this each time something goes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhead change to include PR #314 in devel and keep both branches in sync.