Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide peerpods and peerpodconfigs internal objects #318

Merged
merged 1 commit into from May 26, 2023

Conversation

Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
@snir911
Copy link
Contributor Author

snir911 commented May 23, 2023

cc @bpradipt @jensfr @pmores for reviewing

@openshift-ci openshift-ci bot requested review from bpradipt and pmores May 23, 2023 14:34
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
It's a simple change and helps with the user experience. Thanks @snir911

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2023
@tbuskey
Copy link
Contributor

tbuskey commented May 24, 2023

premerge - I don't see the PeerPod APIs. They're invisible as they should be.

image

I get an error installing kataconfig:
installationStatus:
IsInProgress: "True"
completed: {}
failed:
failedNodesReason: 'Node tbuskey-230524-2-6nbhl-worker-eastus1-t9hkp is reporting:
"invalid extensions found: [kata-containers]"'
inprogress: {}
runtimeClass: ""

@tbuskey
Copy link
Contributor

tbuskey commented May 25, 2023

pre-merge success!
/lgtm
/approve

@jensfr jensfr merged commit 50616c6 into openshift:peer-pods-tech-preview May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants