Allow to skip go test
#320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
pmores
approved these changes
May 25, 2023
There was a problem hiding this comment.
I believe this is a good if not necessary change for the time being. Our approach to make test implementation needs serious rethinking. Until then, the current implementation seems fragile with a lot of false failures and very tedious to maintain while not bringing in much benefit (very few if any bugs were pointed out by make test to my knowledge).
gkurz
removed
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
do-not-merge/work-in-progress
`make test` has been broken since openshift#300 was merged and fixing it is going to take time (see openshift#310 for details). It is a problem for local development since the `test` target is a prequisite for `docker-build` in the makefile. Add a variable to control whether `go test` should run when the `test` target is invoked. $ make test SKIP_TESTS= # Run `go test` when unset $ make test SKIP_TESTS=1 # Don't run `go test` when set Default is unset. Signed-off-by: Greg Kurz <groug@kaod.org>
|
Forced push with |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
cpmeadors
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make testhas been broken since #300 was merged and fixing it is going to take time (see #310 for details). It is a problem for local development since thetesttarget is a prequisite fordocker-buildin the makefile.Add a variable to control whether
go testshould run when thetesttarget is invoked.$ make test SKIP_TESTS= # Run
go testwhen unset$ make test SKIP_TESTS=1 # Don't run
go testwhen setDefault is unset. [edit]
Fixes https://issues.redhat.com/browse/KATA-2167