Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image-job: fix payload url #324

Merged
merged 1 commit into from Jun 12, 2023
Merged

image-job: fix payload url #324

merged 1 commit into from Jun 12, 2023

Conversation

snir911
Copy link
Contributor

@snir911 snir911 commented Jun 8, 2023

devel branch

@snir911
image-job: fix payload url
3b8a810 
Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
cpmeadors
cpmeadors approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@cpmeadors cpmeadors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good. Already tested file with same changes.

littlejawa
littlejawa approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@littlejawa littlejawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Thanks @snir911

@gkurz gkurz added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2023
@gkurz
Copy link
Member

gkurz commented Jun 9, 2023

devel branch

The change is good but the devel branch isn't up to date AFAICT. It seems we should merge main into devel before going ahead with this fix.

gkurz
gkurz approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@gkurz gkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @snir911 !

@gkurz gkurz removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2023
@gkurz gkurz merged commit bd0db5a into openshift:devel Jun 12, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littlejawa littlejawa littlejawa approved these changes

@gkurz gkurz gkurz approved these changes

@cpmeadors cpmeadors cpmeadors approved these changes

@bpradipt bpradipt Awaiting requested review from bpradipt

Assignees

@gkurz gkurz

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@snir911 @gkurz @littlejawa @cpmeadors