peer-pods: validate CM and Secret are set #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkurz
approved these changes
Nov 7, 2023
snir911
force-pushed
the
2557-devel-fix
branch
from
1e6b3c4
to
b1b4bb3
Compare
snir911
added
the
do-not-merge/hold
snir911
force-pushed
the
2557-devel-fix
branch
2 times, most recently
from
4b751a4
to
b209fd4
Compare
snir911
removed
the
do-not-merge/hold
|
Premerge testing successful. |
cpmeadors
approved these changes
Nov 8, 2023
|
Hi @snir911 ! I had approved your original submission as the change was simple to understand, despite the lack of change log. I must admit that now things are a lot harder... Not sure if I'll be able to approve this PR today if I need to guess everything by myself. |
gkurz
requested changes
Nov 9, 2023
We usually fetching cloud-provider name from either the peer-pods CM CLOUD_PROVIDER value or from the infra object, as cloud provider is not expected to be changed at runtime this commit moves its fetching into the image-generator initialization. Additionally fetching the cloud-provider solely from the infra Object to avoid relying on user input (from peer-pods CM) Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
in peer-pods ConfigMap or Secret it's assumed essential values will not be modified once set and kataConfig was created Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
snir911
force-pushed
the
2557-devel-fix
branch
from
b209fd4
to
7de0bf7
Compare
gkurz
reviewed
Nov 9, 2023
gkurz
reviewed
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.