Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image-generator: add CLOUD_PROVIDER variable to job scripts #364

Merged
merged 1 commit into from Dec 8, 2023
Merged

image-generator: add CLOUD_PROVIDER variable to job scripts #364

merged 1 commit into from Dec 8, 2023

Conversation

snir911
Copy link
Contributor

@snir911 snir911 commented Nov 23, 2023 •
edited by openshift-ci bot

Fixes: KATA-2583

@snir911
image-generator: add CLOUD_PROVIDER variable to job scripts
84800f4 
so in case it's missing everything will keep working

Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
@snir911 snir911 self-assigned this Nov 23, 2023
@snir911 snir911 added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 23, 2023
@cpmeadors
Copy link
Contributor

@snir911 Could you add a description for this PR and include any open issues that this resolves?

gkurz
gkurz approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@gkurz gkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm . Thanks @snir911 !

@gkurz
Copy link
Member

gkurz commented Dec 8, 2023

/override ci/prow/check

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 8, 2023

@gkurz: Overrode contexts on behalf of gkurz: ci/prow/check

In response to this:

/override ci/prow/check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 8, 2023

@snir911: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

beraldoleal
beraldoleal approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@beraldoleal beraldoleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@beraldoleal
Copy link
Member

beraldoleal commented Dec 8, 2023 •
edited

@snir911 Could you add a description for this PR and include any open issues that this resolves?

Probably we will not catch this "fixes" automatically, because is not part of the commit message. Not sure, tho, lets see.

@gkurz gkurz merged commit 9d1e2e7 into openshift:devel Dec 8, 2023
3 checks passed
@gkurz gkurz mentioned this pull request Dec 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beraldoleal beraldoleal beraldoleal approved these changes

@gkurz gkurz gkurz approved these changes

@bpradipt bpradipt Awaiting requested review from bpradipt

@pmores pmores Awaiting requested review from pmores

Assignees

@snir911 snir911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@snir911 @cpmeadors @gkurz @beraldoleal