Merge to main for 1.5.2 #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* at creation: name images with unique naming to aviod name reuse failures * at deletion: ignore if image is already deleted Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
KATA-815 Document must-gather for developers
We only want to highlight the variable part in the file names, i.e. the '*' wildcard character for the logs, like already done for the CRD descriptions a few lines below. Fixes: KATA-815 Signed-off-by: Greg Kurz <groug@kaod.org>
All CRD lines should have the same indentation in the non-rendered file for clarity. This has no effect on rendering, which already aligns list elements. Fixes: KATA-815 Signed-off-by: Greg Kurz <groug@kaod.org>
Fix md formatting
image-generator: fix image creation edge cases
|
/override ci/prow/check |
|
@gkurz: Overrode contexts on behalf of gkurz: ci/prow/check In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
littlejawa
approved these changes
Feb 2, 2024
|
@gkurz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
pmores
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Description of the problem which is fixed/What is the use case
This brings fixes for :
https://issues.redhat.com/browse/KATA-2618
Other changes only affect documentation within the repo.
- What I did
- How to verify it
- Description for the changelog
#365
#369
#370