Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the podvm-payload image references #393

Merged
merged 1 commit into from Apr 5, 2024
Merged

Fix the podvm-payload image references #393

merged 1 commit into from Apr 5, 2024

Conversation

bpradipt
Copy link
Contributor

@bpradipt bpradipt commented Apr 5, 2024

Ensure release tag is used

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 5, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bpradipt bpradipt marked this pull request as ready for review April 5, 2024 06:29
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2024
@bpradipt bpradipt requested a review from gkurz April 5, 2024 06:29
@openshift-ci openshift-ci bot requested review from cpmeadors and jensfr April 5, 2024 06:30
@bpradipt
fix image references
c783681 
Ensure we use version tag instead of latest

Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
gkurz
gkurz approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@gkurz gkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm. Thanks @bpradipt !

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 5, 2024

@bpradipt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sandboxed-containers-operator-e2e c783681 link false /test sandboxed-containers-operator-e2e
ci/prow/check c783681 link false /test check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gkurz gkurz merged commit 59d918f into openshift:main Apr 5, 2024
2 of 4 checks passed
@bpradipt bpradipt deleted the fix-image-1.5.3 branch April 5, 2024 10:43
gkurz added a commit to gkurz/sandboxed-containers-operator that referenced this pull request Apr 8, 2024
@gkurz
Revert "Merge pull request openshift#393 from bpradipt/fix-image-1.5.3"
65a0f53 
This reverts commit 59d918f, reversing
changes made to b57ba2c.

Signed-off-by: Greg Kurz <groug@kaod.org>
gkurz added a commit to gkurz/sandboxed-containers-operator that referenced this pull request Apr 8, 2024
@gkurz
Revert "Merge pull request openshift#393 from bpradipt/fix-image-1.5.3"
228c5ed 
This reverts commit 59d918f, reversing
changes made to b57ba2c.

Fixes: KATA-2876

Signed-off-by: Greg Kurz <groug@kaod.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkurz gkurz gkurz approved these changes

@cpmeadors cpmeadors Awaiting requested review from cpmeadors

@jensfr jensfr Awaiting requested review from jensfr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bpradipt @gkurz