Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fqdn for node names #69

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Use fqdn for node names #69

merged 1 commit into from
Mar 10, 2021

Conversation

bpradipt
Copy link
Contributor

Fixes #68

- Description of the problem which is fixed/What is the use case
Fixes failed uninstall of Kata runtime when Kata is installed on specific nodes

- What I did
Used fqdn for nodename instead of host name

- How to verify it
Build the kata-operator-daemon and push the image to registry. Thereafter modify kata-operator to use the kata-operator-daemon image and go through the install/uninstall cycle

- Description for the changelog

Use FQDN for nodename

@bpradipt
Copy link
Contributor Author

@jensfr this scenario definitely needs a test case. Will add it post merge of #62

Copy link
Contributor

@jensfr jensfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Pradipta, lgtm!

Copy link
Contributor

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bpradipt,

I'd like to ask one thing ... are there situations where we would need the os.Hostname()?

If not, I think we could entirely get rid of getHostName(), which is only called from getNodeName() (mind, this is not required for this PR, just ideas for the future).

@fidencio
Copy link
Contributor

Anyways, this is approved already, we can keep discussing the improvements for the future, but I will not block it to get merged. :-)

@fidencio fidencio merged commit f4e0d48 into openshift:master Mar 10, 2021
@bpradipt bpradipt deleted the fix-68 branch March 10, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uninstall fails due to incorrect node name when Kata is installed on selected nodes
3 participants