inform user if kata uninstallation is blocked by existing kata-based … #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pods If user requests uninstallation of Kata by deleting their KataConfig instance, the request cannot be fulfilled if there still are pods that use Kata as runtime. So far, the controller logged a message on detecting this condition but since the message went to the controller log it wasn't very well visible or discoverable. This change creates a new field in KataConfig status to communicate the error to the user more effectively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pods
If user requests uninstallation of Kata by deleting their KataConfig
instance, the request cannot be fulfilled if there still are pods that use
Kata as runtime. So far, the controller logged a message on detecting this
condition but since the message went to the controller log it wasn't very
well visible or discoverable.
This change creates a new field in KataConfig status to communicate the
error to the user more effectively.
- Description of the problem which is fixed/What is the use case
- What I did
- How to verify it
- Description for the changelog