Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1812052: Update HACKING.md rebase to use go modules #117

Merged
merged 1 commit into from Apr 8, 2020
Merged

Bug 1812052: Update HACKING.md rebase to use go modules #117

merged 1 commit into from Apr 8, 2020

Conversation

juanluisvaladas
Copy link
Contributor

I forgot to update HACKING.md after the migration to go modules.
This includes it.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 10, 2020
@openshift-ci-robot
Copy link
Contributor

@juanluisvaladas: This pull request references Bugzilla bug 1812052, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1812052: Update HACKING.md rebase to use go modules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 10, 2020
@juanluisvaladas juanluisvaladas mentioned this pull request Mar 10, 2020
Merged
JacobTanenbaum
JacobTanenbaum reviewed Mar 11, 2020
View reviewed changes
HACKING.md Outdated Show resolved Hide resolved
HACKING.md Outdated Show resolved Hide resolved
@juanluisvaladas juanluisvaladas force-pushed the update-hacking.md branch 2 times, most recently from 03ae89a to 49f17a0 Compare March 11, 2020 09:25
danwinship
danwinship reviewed Mar 18, 2020
View reviewed changes
HACKING.md Show resolved Hide resolved
HACKING.md Outdated Show resolved Hide resolved
HACKING.md Outdated Show resolved Hide resolved
HACKING.md Outdated Show resolved Hide resolved
HACKING.md Show resolved Hide resolved
@juanluisvaladas
Copy link
Contributor Author

@danwinship can you please review again? the only changes are regarding your comments

@danwinship
Copy link
Contributor

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, juanluisvaladas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2020
@openshift-merge-robot openshift-merge-robot merged commit e133445 into openshift:master Apr 8, 2020
@openshift-ci-robot
Copy link
Contributor

@juanluisvaladas: All pull requests linked via external trackers have merged: openshift/sdn#117. Bugzilla bug 1812052 has been moved to the MODIFIED state.

In response to this:

Bug 1812052: Update HACKING.md rebase to use go modules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juanluisvaladas juanluisvaladas mentioned this pull request May 5, 2020
Merged
@juanluisvaladas juanluisvaladas deleted the update-hacking.md branch May 5, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship danwinship left review comments

@JacobTanenbaum JacobTanenbaum JacobTanenbaum left review comments

@pecameron pecameron Awaiting requested review from pecameron

Assignees

@danwinship danwinship

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@juanluisvaladas @openshift-ci-robot @danwinship @JacobTanenbaum @openshift-merge-robot