Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.5] Bug 1878624: Invalid egressCIDR value causes sdn pods to fail on startup #187

Merged
merged 2 commits into from Oct 14, 2020
Merged

[release-4.5] Bug 1878624: Invalid egressCIDR value causes sdn pods to fail on startup #187

merged 2 commits into from Oct 14, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #169

/assign tssurya

@tssurya
Bug 1848478: Invalid egressCIDR value causes sdn pods to fail on startup
55e4452 
HostSubnet is half system-maintained (subnet allocations) and half
user-maintained (EgressIPs). If there is any invalid value that is set
on the user-maintained fields, we should just ignore them and continue
with the SDN startup procedure instead of failing.

In this patch we remove the validation of the user-maintained fields
from ValidateHostSubnet function. We can do a separate validation for
the user-maintained fields.

Signed-off-by: Surya Seetharaman suryaseetharaman.9@gmail.com
@tssurya
Add ValidateHostSubnetEgress function to validate egress cidrs/ips
9609b7f 
We don't have a proper validation procedure for egress ips/cidrs.
This patch adds a ValidateHostSubnetEgress function which will
check for the validity of the user-maintained values in the hostsubet
object.

Signed-off-by: Surya Seetharaman suryaseetharaman.9@gmail.com
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 14, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1848478 has been cloned as Bugzilla bug 1878624. Retitling PR to link against new bug.
/retitle [release-4.5] Bug 1878624: Invalid egressCIDR value causes sdn pods to fail on startup

In response to this:

[release-4.5] Bug 1848478: Invalid egressCIDR value causes sdn pods to fail on startup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] Bug 1848478: Invalid egressCIDR value causes sdn pods to fail on startup [release-4.5] Bug 1878624: Invalid egressCIDR value causes sdn pods to fail on startup Sep 14, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1878624, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1848478 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1848478 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

[release-4.5] Bug 1878624: Invalid egressCIDR value causes sdn pods to fail on startup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 14, 2020
@rcarrillocruz
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2020
@tssurya
Copy link
Contributor

tssurya commented Sep 19, 2020

/retest

@tssurya
Copy link
Contributor

tssurya commented Sep 19, 2020

I also need the lgtm label to get picked by patch-manager, @rcarrillocruz could you also add that please ?

@juanluisvaladas
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanluisvaladas, openshift-cherrypick-robot, rcarrillocruz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmc markmc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 25, 2020
@markmc
Copy link

markmc commented Sep 25, 2020

(patch manager) affecting real world users

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

22 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@tssurya
Copy link
Contributor

tssurya commented Oct 2, 2020

(patch manager) affecting real world users

@markmc can we put the cherry-pick label back ? The e2egcp job was facing some CI cluster issues (openshift/release#12386), that's why so many retests.

@juanluisvaladas
Copy link
Contributor

@tssurya you can ask Ben, hje can also add the cherry-pick-approved label

@tssurya
Copy link
Contributor

tssurya commented Oct 8, 2020

@tssurya you can ask Ben, hje can also add the cherry-pick-approved label

ah really ? I always get confused with this part. I thought only patch-managers for that week could do this and pick up backports.

@juanluisvaladas
Copy link
Contributor

Not sure how that works but he has a lot of privileges

@knobunc knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 14, 2020
@openshift-merge-robot openshift-merge-robot merged commit d62ccd4 into openshift:release-4.5 Oct 14, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1878624 has been moved to the MODIFIED state.

In response to this:

[release-4.5] Bug 1878624: Invalid egressCIDR value causes sdn pods to fail on startup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

@squeed squeed Awaiting requested review from squeed

Assignees

@tssurya tssurya

@juanluisvaladas juanluisvaladas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@openshift-cherrypick-robot @openshift-ci-robot @rcarrillocruz @tssurya @juanluisvaladas @markmc @openshift-bot @knobunc @openshift-merge-robot