New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1878845: Fix ruleversion #204
Bug 1878845: Fix ruleversion #204
Conversation
@juanluisvaladas: This pull request references Bugzilla bug 1878845, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I still need to test the upgrade between 4.5 and 4.6. I'm currently waiting for the 4.5 cluster to deploy. |
In commit a464217 we changed the flows but forgot to increase the ruleVersion. This breaks upgrades in multitenant.
Initially 300 was the highest priority but now we have a rule that is 400, make it 1000 so that it's guaranteed that the flow is always evaluated.
75dfcb7
to
31017cb
Compare
/bugzilla refresh |
@sdodson: This pull request references Bugzilla bug 1878845, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/cherry-pick release-4.6 |
@juanluisvaladas: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juanluisvaladas, rcarrillocruz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-aws |
/skip ci/prow/e2e-aws |
/override ci/prow/e2e-aws |
Overriding since othre jobs passed and we need to expedite this for 4.6 |
@rcarrillocruz: Overrode contexts on behalf of rcarrillocruz: ci/prow/e2e-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@juanluisvaladas: All pull requests linked via external trackers have merged: Bugzilla bug 1878845 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@juanluisvaladas: new pull request created: #206 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In commit a464217 we changed the flows but forgot to increase the ruleVersion. This breaks upgrades in multitenant.
Also since we're here another little bug that isn't breaking anything right now. Initially 300 was the highest priority but now we have a rule that is 400, make it 1000 so that it's guaranteed that the flow is always evaluated.