New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1891455: Fix error handling from DNS nameservers #211
Bug 1891455: Fix error handling from DNS nameservers #211
Conversation
Egress network policy should be able to resolve DNS names. If multiple DNS servers are listed in /etc/resolv.conf and one of these returns an NXDOMAIN response, we, in turn, return an error and skip testing any succeeding nameserver. Instead of returning an error, just continue to the next one. Signed-off-by: Alexander Constantinescu <aconstan@redhat.com>
@alexanderConstantinescu: This pull request references Bugzilla bug 1891455, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh @danwinship / @rcarrillocruz : could any of you lgtm and approve this? |
@alexanderConstantinescu: This pull request references Bugzilla bug 1891455, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderConstantinescu, danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@alexanderConstantinescu: All pull requests linked via external trackers have merged: Bugzilla bug 1891455 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4.5 back-port of #210
Egress network policy should be able to resolve DNS names. If
multiple DNS servers are listed in /etc/resolv.conf and one of these
returns an NXDOMAIN response, we, in turn, return an error and
skip testing any succeeding nameserver.
Instead of returning an error, just continue to the next one.
/assign @rcarrillocruz