Bug 1892376: Ignore if netns is already deleted while deleting ns #214
Conversation
While deleting a namespace, we check and delete the netnamespace and remove the corresponding netid from the masterVNIDMap cache. However if the netns is deleted before the ns, we return an error and do not remove it from the cache. Upon recreation of the same ns/project in the future, a new netns does not get created because according to the masterVNIDMap cache, that netns is already present. In this patch we ignore, emit a warning and continue to remove the netid from the masterVNIDMap cache if the netns is already deleted. There is no point in returning an error if the objective in the end is to have the netns deleted. The order of deletion between netns and ns should not matter. Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
openshift-ci-robot
added
bugzilla/severity-urgent
|
@tssurya: This pull request references Bugzilla bug 1892376, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
requested review from
alexanderConstantinescu and
danwinship
|
I don't know where/if I should add unit tests, there doesn't seem to be a mock for the networkClient portion of things, so the function I touched doesn't have tests. |
|
These sorts of things are notoriously hard to mock out; that's OK. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: squeed, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@tssurya: All pull requests linked via external trackers have merged: Bugzilla bug 1892376 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
thanks casey! /cherry-pick release-4.6 |
|
@tssurya: new pull request created: #216 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
While deleting a namespace, we check and delete the netnamespace
and remove the corresponding netid from the masterVNIDMap cache.
However if the netns is deleted before the ns, we return an error
and do not remove it from the cache. Upon recreation of the same
ns/project in the future, a new netns does not get created because
according to the masterVNIDMap cache, that netns is already present.
In this patch we ignore, emit a warning and continue to remove the
netid from the masterVNIDMap cache if the netns is already deleted.
There is no point in returning an error if the objective in the end
is to have the netns deleted. The order of deletion between netns
and ns should not matter.
Signed-off-by: Surya Seetharaman suryaseetharaman.9@gmail.com