New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1897073: Don't throw an error for control plane VNID #220
Bug 1897073: Don't throw an error for control plane VNID #220
Conversation
/assign @danwinship |
/retest |
/bugzilla refresh |
@juanluisvaladas: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retitle Bug 1897073: Don't throw an error for control plane VNID |
/bugzilla refresh |
@juanluisvaladas: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@juanluisvaladas: This pull request references Bugzilla bug 1897073, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@juanluisvaladas: This pull request references Bugzilla bug 1897073, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Initially VNIDs 1-9 were forbidden, in OpenShift 4 we need the control plane components to communicate with each other, so we assigned netid 1 to it. In the future we may need more so we're not logging any message with vnid < 10.
a15117d
to
225e2d9
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, juanluisvaladas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@juanluisvaladas: All pull requests linked via external trackers have merged: Bugzilla bug 1897073 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Initially VNIDs 1-9 were forbidden, in OpenShift 4 we need the control
plane components to communicate with each other, so we assigned netid 1 to
it. This is logging an error incorrectly.