Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.7] Bug 1962637: ValidateMTU: check only the interface that holds the node ip #304

Merged
merged 1 commit into from Jun 4, 2021
Merged

[release-4.7] Bug 1962637: ValidateMTU: check only the interface that holds the node ip #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 13 additions & 0 deletions pkg/network/node/node.go
View file
Open in desktop
Expand Up @@ -268,6 +268,19 @@ func (node *OsdnNode) validateMTU() error {
return fmt.Errorf("could not retrieve link id %d while validating MTU", route.LinkIndex)
}

// we want to check the mtu only for the interface assigned to the node's primary ip
found := false
addresses, err := netlink.AddrList(link, netlink.FAMILY_V4)
for _, address := range addresses {
if node.localIP == address.IP.String() {
found = true
break
}
}
if !found {
continue
}

newmtu := link.Attrs().MTU
if newmtu > 0 && newmtu < mtu {
mtu = newmtu
Expand Down