[release-4.7] Bug 1971669: Fix 4.7 SDN Egress Network Policy

[astoycos]

Previoulsy we added a flow to send reply traffic
to table 101(the ENP table) but in reality ENP
should never match on repy traffic so instead
just send it out.

This seems to already be fixed in 4.8 and greater with #299 However it can't be
simply backported due to https://coreos.slack.com/archives/CDCP2LA9L/p1628667498274000?thread_ts=1628601796.223900&cid=CDCP2LA9L

 That fix was only needed because of a recent feature development for egress IP in openshift-sdn on 4.8 which broke egress network policy, that made it in before 4.8 code freeze though, and the problem never existed on 4.7. So, I am not sure it's safe to backport to 4.7 and risk breaking something else. This seems like it deserves its own fix

Signed-off-by: astoycos astoycos@redhat.com

[openshift-ci]

@astoycos: This pull request references Bugzilla bug 1971669, which is invalid:

• expected the bug to target the "4.7.z" release, but it targets "---" instead
• expected Bugzilla bug 1971669 to depend on a bug targeting a release in 4.8.0, 4.8.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1971669: Fix 4.7 SDN Egress Network Policy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[astoycos]

/retest

[astoycos]

/assign @danwinship

[openshift-ci]

@astoycos: This pull request references Bugzilla bug 1971669, which is invalid:

• expected the bug to target the "4.7.z" release, but it targets "---" instead
• expected Bugzilla bug 1971669 to depend on a bug targeting a release in 4.8.0, 4.8.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1971669: Fix 4.7 SDN Egress Network Policy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[astoycos]

/bugzilla refresh

[openshift-ci]

@astoycos: This pull request references Bugzilla bug 1971669, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.z) matches configured target release for branch (4.7.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1959711 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 1959711 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0, 4.8.z
• bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[danwinship]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astoycos, danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [danwinship]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deads2k]

(patch manager)

high bz, 1.5

[openshift-ci]

@astoycos: All pull requests linked via external trackers have merged:

• openshift/sdn#334

Bugzilla bug 1971669 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1971669: Fix 4.7 SDN Egress Network Policy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.