Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.6] Bug 1998453: Fix MCS-blocking iptables rules #340

Conversation

creydr
Copy link
Member

@creydr creydr commented Aug 30, 2021

Cherry-pick of #243 for 4.6

They should only block connections TO those ports, not inbound replies
to connections that happened to use those source ports.
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Aug 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2021

@creydr: This pull request references Bugzilla bug 1998453, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1915027 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1915027 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

[release-4.6] Bug 1998453: Fix MCS-blocking iptables rules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 30, 2021
@danwinship
Copy link
Contributor

/lgtm

This bug only affected one customer that we know of, but it's an easy and safe fix.
(And even if it doesn't consistently break anyone else, it will still randomly break roughly 1 out of 32,768 connections for everybody...)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2021
@dmunne
Copy link

dmunne commented Sep 1, 2021

@knobunc / @dcbw, can you help with the cherry-pick-approved label?
Thanks!

@creydr
Copy link
Member Author

creydr commented Sep 8, 2021

@knobunc / @dcbw can you help @dmunne here with the cherry-pick-approved label?
Thanks

@mfojtik mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 9, 2021
@mfojtik
Copy link
Member

mfojtik commented Sep 9, 2021

[patch-manager] 🚀 Approved for z-stream by score: 1.00

adding cherry-pick approved

@openshift-merge-robot openshift-merge-robot merged commit 59096ce into openshift:release-4.6 Sep 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2021

@creydr: All pull requests linked via external trackers have merged:

Bugzilla bug 1998453 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1998453: Fix MCS-blocking iptables rules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants