OCPBUGS-256: fix network policy egress

[JacobTanenbaum]

in the case where an egress rule has no namespaceSelector and an empty pod Selector we generate a flow fmt.Sprintf("reg1=%d, ", npns.vnid), that is wrong because reg1 is not set at this point.

the egress flows need to be generated using only podIPs rather then VNIDs for egress flows

[openshift-ci-robot]

@JacobTanenbaum: This pull request references Jira Issue OCPBUGS-256, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.12.0) matches configured target version for branch (4.12.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

in the case where an egress rule has no namespaceSelector and an empty pod Selector we generate a flow fmt.Sprintf("reg1=%d, ", npns.vnid), that is wrong because reg1 is not set at this point.

the egress flows need to be generated using only podIPs rather then VNIDs for egress flows

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JacobTanenbaum]

/retest

[danwinship]

/lgtm

[danwinship]

/lgtm cancel
actually can you update TestNetworkPolicy_egress to cover this case?

[danwinship]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, JacobTanenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [danwinship]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[danwinship]

/hold
e2e tests are actually running against ovn-kubernetes 🙁

[openshift-ci]

@JacobTanenbaum: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws	12acfb2	link	true	/test e2e-aws
ci/prow/e2e-aws-serial	12acfb2	link	true	/test e2e-aws-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[danwinship]

/hold cancel
/retest-required

[openshift-ci-robot]

@JacobTanenbaum: All pull requests linked via external trackers have merged:

• openshift/sdn#459

Jira Issue OCPBUGS-256 has been moved to the MODIFIED state.

In response to this:

in the case where an egress rule has no namespaceSelector and an empty pod Selector we generate a flow fmt.Sprintf("reg1=%d, ", npns.vnid), that is wrong because reg1 is not set at this point.

the egress flows need to be generated using only podIPs rather then VNIDs for egress flows

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[danwinship]

/cherry-pick release-4.11

[openshift-cherrypick-robot]

@danwinship: new pull request created: #491

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.