Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.8] OCPBUGS-16872: Add /usr/bin/oc to image simiar to openshift-ovn-kubernetes #565

Merged
merged 1 commit into from Jul 28, 2023
Merged

[release-4.8] OCPBUGS-16872: Add /usr/bin/oc to image simiar to openshift-ovn-kubernetes #565

merged 1 commit into from Jul 28, 2023

Conversation

jcaamano
Copy link
Contributor

Signed-off-by: Michael Cambria mcambria@redhat.com
(cherry picked from commit b0e58ad) (cherry picked from commit 1ecde80)

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 27, 2023
@openshift-ci-robot
Copy link
Contributor

@jcaamano: This pull request references Jira Issue OCPBUGS-16872, which is invalid:

  • expected Jira Issue OCPBUGS-16872 to depend on a bug targeting a version in 4.9.0, 4.9.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Signed-off-by: Michael Cambria mcambria@redhat.com
(cherry picked from commit b0e58ad) (cherry picked from commit 1ecde80)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor

dcbw commented Jul 27, 2023

/retest

@dcbw
Copy link
Contributor

dcbw commented Jul 27, 2023

/test images

jupierce
jupierce reviewed Jul 27, 2023
View reviewed changes
images/sdn/Dockerfile.rhel Outdated
@@ -21,6 +21,9 @@ COPY --from=rhel8-builder /go/src/github.com/openshift/sdn/host-local /usr/bin/c
RUN mkdir -p /opt/cni/bin/rhel7
COPY --from=rhel7-builder /go/src/github.com/openshift/sdn/sdn-cni-plugin /opt/cni/bin/rhel7/openshift-sdn

FROM registry.ci.openshift.org/ocp/4.8:cli AS cli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move FROM registry.ci.openshift.org/ocp/4.8:cli AS cli above FROM registry.ci.openshift.org/ocp/4.8:base else you are copying the binary onto itself.

@mccv1r0 @jcaamano
Add /usr/bin/oc to image simiar to openshift-ovn-kubernetes
94eb5e8 
Signed-off-by: Michael Cambria <mcambria@redhat.com>
(cherry picked from commit b0e58ad)
(cherry picked from commit 1ecde80)
@jcaamano
Copy link
Contributor Author

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 27, 2023
@jechen0648
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2023

@jcaamano: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dcbw
Copy link
Contributor

dcbw commented Jul 28, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, jcaamano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2023
@dcbw
Copy link
Contributor

dcbw commented Jul 28, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@dcbw: This pull request references Jira Issue OCPBUGS-16872, which is invalid:

  • expected Jira Issue OCPBUGS-16872 to depend on a bug targeting a version in 4.9.0, 4.9.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor

dcbw commented Jul 28, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 28, 2023
@openshift-ci-robot
Copy link
Contributor

@dcbw: This pull request references Jira Issue OCPBUGS-16872, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.8.z) matches configured target version for branch (4.8.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-16894 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-16894 targets the "4.9.z" version, which is one of the valid target versions: 4.9.0, 4.9.z
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from zhaozhanqi July 28, 2023 00:15
@openshift-merge-robot openshift-merge-robot merged commit c4c2414 into openshift:release-4.8 Jul 28, 2023
8 checks passed
@openshift-ci-robot
Copy link
Contributor

@jcaamano: Jira Issue OCPBUGS-16872 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

Signed-off-by: Michael Cambria mcambria@redhat.com
(cherry picked from commit b0e58ad) (cherry picked from commit 1ecde80)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jul 28, 2023
Merged
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build kube-proxy-container-v4.8.0-202311261141.p0.gc4c2414.assembly.stream for distgit kube-proxy.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jupierce jupierce jupierce left review comments

@danielmellado danielmellado Awaiting requested review from danielmellado

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@zhaozhanqi zhaozhanqi

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet