Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-25036: Use openshift-clients rpm rather than cli image #593

Merged
merged 1 commit into from Dec 16, 2023
Merged

OCPBUGS-25036: Use openshift-clients rpm rather than cli image #593

merged 1 commit into from Dec 16, 2023

Conversation

joepvd
Copy link
Contributor

@joepvd joepvd commented Dec 8, 2023

No description provided.

@joepvd joepvd mentioned this pull request Dec 8, 2023
Merged
@joepvd
Copy link
Contributor Author

joepvd commented Dec 8, 2023

Test production build: https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=2810803

@dcbw
Copy link
Contributor

dcbw commented Dec 8, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, joepvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2023
@dcbw
Copy link
Contributor

dcbw commented Dec 8, 2023

/retest

@dcbw
Copy link
Contributor

dcbw commented Dec 8, 2023

/hold

till we figure out why tests are failing

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2023
@joepvd
Copy link
Contributor Author

joepvd commented Dec 9, 2023

/retest

1 similar comment
@joepvd
Copy link
Contributor Author

joepvd commented Dec 11, 2023

/retest

@joepvd joepvd changed the title Use openshift-clients rpm rather than cli image OCPBUGS-25036: Use openshift-clients rpm rather than cli image Dec 11, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 11, 2023
@openshift-ci-robot
Copy link
Contributor

@joepvd: This pull request references Jira Issue OCPBUGS-25036, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joepvd
Copy link
Contributor Author

joepvd commented Dec 11, 2023

Test build: https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=2810803

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 11, 2023

@joepvd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joepvd
Copy link
Contributor Author

joepvd commented Dec 16, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 1818c78 into openshift:master Dec 16, 2023
9 checks passed
@openshift-ci-robot
Copy link
Contributor

@joepvd: Jira Issue OCPBUGS-25036: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-25036 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build kube-proxy-container-v4.16.0-202312161710.p0.g1818c78.assembly.stream for distgit kube-proxy.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@tssurya tssurya Awaiting requested review from tssurya

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

Assignees

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joepvd @dcbw @openshift-ci-robot @openshift-bot