SDN-4179: Metrics: Add metric for multicast enabled netnamespaces #603
Conversation
Signed-off-by: Peng Liu <pliu@redhat.com>
openshift-ci-robot
added
the
jira/valid-reference
|
@pliurh: This pull request references SDN-4179 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @martinkennelly |
|
/retest |
|
@pliurh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| var metricMulticastEnabledNamespaceCount = prometheus.NewGauge(prometheus.GaugeOpts{ | ||
| Namespace: metricSDNNamespace, | ||
| Subsystem: metricSDNSubsystemController, | ||
| Name: "num_multicast_enabled_namespaces", |
There was a problem hiding this comment.
not suggesting a change here because youre following existing naming convention, but for your own info here is the prometheus naming guide: https://prometheus.io/docs/practices/naming/
|
/assign @danwinship |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, martinkennelly, pliurh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
[ART PR BUILD NOTIFIER] This PR has been included in build kube-proxy-container-v4.16.0-202401051633.p0.g5ad1921.assembly.stream for distgit kube-proxy. |
|
/cherry-pick release-4.15 |
|
@pliurh: new pull request created: #606 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.