Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1782847: sdn: undo debug logging #84

Merged
merged 1 commit into from Dec 12, 2019

Conversation

squeed
Copy link
Contributor

@squeed squeed commented Dec 12, 2019

It was added to track down the informer issue; we caught it. It causes logs to be way too large.

It was added to track down the informer issue; we caught it. It causes
logs to be way too large.
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 12, 2019
@squeed squeed changed the title sdn: undo debug logging Bug 1782847:sdn: undo debug logging Dec 12, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 12, 2019
@openshift-ci-robot
Copy link
Contributor

@squeed: This pull request references Bugzilla bug 1782847, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1782847:sdn: undo debug logging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@squeed squeed changed the title Bug 1782847:sdn: undo debug logging Bug 1782847: sdn: undo debug logging Dec 12, 2019
@squeed
Copy link
Contributor Author

squeed commented Dec 12, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 12, 2019
@openshift-ci-robot
Copy link
Contributor

@squeed: This pull request references Bugzilla bug 1782847, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 12, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2019
@squeed
Copy link
Contributor Author

squeed commented Dec 12, 2019

I want to backport this to 4.3.0 before it releases. Thus, this is pretty important. @juanluisvaladas can you review?

@danwinship
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2019
@juanluisvaladas
Copy link
Contributor

/lgtm
Commit with adding the additional logging: https://github.com/openshift/sdn/commit43452fe37f51a41ea1d56dd66dda9ae1d10bbda7

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, juanluisvaladas, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b11fda8 into openshift:master Dec 12, 2019
@openshift-ci-robot
Copy link
Contributor

@squeed: All pull requests linked via external trackers have merged. Bugzilla bug 1782847 has been moved to the MODIFIED state.

In response to this:

Bug 1782847: sdn: undo debug logging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@squeed
Copy link
Contributor Author

squeed commented Dec 12, 2019

/cherry-pick release-4.3

@squeed
Copy link
Contributor Author

squeed commented Dec 12, 2019

/cherrypick release-4.3

@openshift-cherrypick-robot

@squeed: #84 failed to apply on top of branch "release-4.2":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	pkg/openshift-sdn/informers.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/openshift-sdn/informers.go
CONFLICT (content): Merge conflict in pkg/openshift-sdn/informers.go
Patch failed at 0001 sdn: undo debug logging

In response to this:

/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@squeed: new pull request created: #85

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@squeed: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/openshift-cherrypick-robot/sdn\n ! [rejected] cherry-pick-84-to-release-4.3 -> cherry-pick-84-to-release-4.3 (fetch first)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:CENSORED@github.com/openshift-cherrypick-robot/sdn'\nhint: Updates were rejected because the remote contains work that you do\nhint: not have locally. This is usually caused by another repository pushing\nhint: to the same ref. You may want to first integrate the remote changes\nhint: (e.g., 'git pull ...') before pushing again.\nhint: See the 'Note about fast-forwards' in 'git push --help' for details.\n", error: exit status 1

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants