Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1794022: Update deps, including informer fix #93

Merged
merged 3 commits into from Jan 24, 2020
Merged

Bug 1794022: Update deps, including informer fix #93

merged 3 commits into from Jan 24, 2020

Conversation

danwinship
Copy link
Contributor

@danwinship danwinship commented Jan 20, 2020 •
edited

  • make update-deps
  • belatedly update openshift deps to release-4.3 branches
  • Use k8s.io/client-go fork with informer fix

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 20, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2020
This was referenced Jan 20, 2020
Merged
Merged
@danwinship
Copy link
Contributor Author

/test all

1 similar comment
@danwinship
Copy link
Contributor Author

/test all

@danwinship danwinship mentioned this pull request Jan 22, 2020
Closed
@danwinship danwinship changed the title WIP: Use k8s.io/client-go fork with informer fix, run update-deps Use k8s.io/client-go fork with informer fix, run update-deps Jan 22, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2020
@danwinship danwinship changed the title Use k8s.io/client-go fork with informer fix, run update-deps Update deps, including informer fix Jan 22, 2020
@danwinship danwinship changed the title Update deps, including informer fix Bug 1794022: Update deps, including informer fix Jan 22, 2020
@openshift-ci-robot
Copy link
Contributor

@danwinship: This pull request references Bugzilla bug 1794022, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1794022: Update deps, including informer fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 22, 2020
@danwinship
Copy link
Contributor Author

/retest

knobunc
knobunc reviewed Jan 24, 2020
View reviewed changes
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5407e33 into openshift:master Jan 24, 2020
@openshift-ci-robot
Copy link
Contributor

@danwinship: All pull requests linked via external trackers have merged. Bugzilla bug 1794022 has been moved to the MODIFIED state.

In response to this:

Bug 1794022: Update deps, including informer fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship danwinship deleted the fork-k8s-client-go branch January 25, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knobunc knobunc knobunc left review comments

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@pecameron pecameron Awaiting requested review from pecameron

Assignees

@knobunc knobunc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@danwinship @openshift-ci-robot @openshift-bot @knobunc @openshift-merge-robot