-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-28584: deploy: add get/list/watch permissions to infrastructure object #126
OCPBUGS-28584: deploy: add get/list/watch permissions to infrastructure object #126
Conversation
@flavianmissi: This pull request references Jira Issue OCPBUGS-28584, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@flavianmissi: This pull request references Jira Issue OCPBUGS-28584, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
this permission is used by library-go `ControllerBuilder.Run` to discover cluster topology and setup leader election based on that.
8791895
to
a87c43e
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flavianmissi, ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@flavianmissi: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3be715c
into
openshift:master
@flavianmissi: Jira Issue OCPBUGS-28584: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-28584 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cherry-pick release-4.15 |
@flavianmissi: new pull request created: #127 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
this is used by library-go
ControllerBuilder.Run
to discover cluster topology and setup leader election based on that.--
There isn't a lot of use in this for this operator as I doubt SNO clusters will be using the secondary scheduler 馃
Regardless, this PR should silent the warn seen in the logs.