Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-28584: deploy: add get/list/watch permissions to infrastructure object #126

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

flavianmissi
Copy link
Member

this is used by library-go ControllerBuilder.Run to discover cluster topology and setup leader election based on that.

--

There isn't a lot of use in this for this operator as I doubt SNO clusters will be using the secondary scheduler 馃
Regardless, this PR should silent the warn seen in the logs.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 30, 2024
@openshift-ci-robot
Copy link

@flavianmissi: This pull request references Jira Issue OCPBUGS-28584, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

this is used by library-go ControllerBuilder.Run to discover cluster topology and setup leader election based on that.

--

There isn't a lot of use in this for this operator as I doubt SNO clusters will be using the secondary scheduler 馃
Regardless, this PR should silent the warn seen in the logs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@flavianmissi
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 30, 2024
@openshift-ci-robot
Copy link

@flavianmissi: This pull request references Jira Issue OCPBUGS-28584, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @kasturinarra

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

this permission is used by library-go `ControllerBuilder.Run` to discover
cluster topology and setup leader election based on that.
@ingvagabund
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2024
Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

@flavianmissi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security a87c43e link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3be715c into openshift:master Jan 30, 2024
5 of 6 checks passed
@openshift-ci-robot
Copy link

@flavianmissi: Jira Issue OCPBUGS-28584: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28584 has been moved to the MODIFIED state.

In response to this:

this is used by library-go ControllerBuilder.Run to discover cluster topology and setup leader election based on that.

--

There isn't a lot of use in this for this operator as I doubt SNO clusters will be using the secondary scheduler 馃
Regardless, this PR should silent the warn seen in the logs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@flavianmissi flavianmissi deleted the OCPBUGS-28584 branch January 30, 2024 15:49
@flavianmissi
Copy link
Member Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@flavianmissi: new pull request created: #127

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants