Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-1828: Limit must-gather log collection by timestamps #48

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

jsafrane
Copy link
Contributor

Use MUST_GATHER_SINCE and MUST_GATHER_SINCE_TIME env. vars to limit log collection. They are set by oc adm must-gather --since or --since-time.

Tested by:

oc adm must-gather --image=quay.io/jsafrane/scratch:ssmg1 --since=5m

This PR contains a partial copy of https://github.com/openshift/must-gather/blob/a175e0178104f4f794828c02245cd2de896cef0e/collection-scripts/common.sh, I haven't found a way how to share the script nicely.

Use MUST_GATHER_SINCE and MUST_GATHER_SINCE_TIME env. vars to limit log collection. They are set by `oc adm must-gather --since` or `--since-time`.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 10, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 10, 2024

@jsafrane: This pull request references STOR-1828 which is a valid jira issue.

In response to this:

Use MUST_GATHER_SINCE and MUST_GATHER_SINCE_TIME env. vars to limit log collection. They are set by oc adm must-gather --since or --since-time.

Tested by:

oc adm must-gather --image=quay.io/jsafrane/scratch:ssmg1 --since=5m

This PR contains a partial copy of https://github.com/openshift/must-gather/blob/a175e0178104f4f794828c02245cd2de896cef0e/collection-scripts/common.sh, I haven't found a way how to share the script nicely.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jsafrane
Copy link
Contributor Author

cc @openshift/storage

Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
@jsafrane
Copy link
Contributor Author

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Apr 10, 2024
Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

@jsafrane: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dobsonj
Copy link
Member

dobsonj commented Apr 11, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2024
@duanwei33
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 12, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 12, 2024

@jsafrane: This pull request references STOR-1828 which is a valid jira issue.

In response to this:

Use MUST_GATHER_SINCE and MUST_GATHER_SINCE_TIME env. vars to limit log collection. They are set by oc adm must-gather --since or --since-time.

Tested by:

oc adm must-gather --image=quay.io/jsafrane/scratch:ssmg1 --since=5m

This PR contains a partial copy of https://github.com/openshift/must-gather/blob/a175e0178104f4f794828c02245cd2de896cef0e/collection-scripts/common.sh, I haven't found a way how to share the script nicely.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 81d3704 into openshift:main Apr 12, 2024
8 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-secrets-store-csi-mustgather-container-v4.16.0-202404121144.p0.g81d3704.assembly.stream.el9 for distgit ose-secrets-store-csi-mustgather.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants