Fix (make verify) with Go 1.16 #142
Conversation
failing with > go vet -mod=vendor ./... > # github.com/openshift/service-ca-operator/test/util > test/util/rotate.go:113:4: call to (*T).Fatalf from a non-test goroutine Aborting the test from inside a goroutine is invalid; instead, just mark the test as failed, and let the client on the main goroutine time out. By default, that waits too long and the test fails with a generic "timed out" panic, and no record of the cause, so impose a 1-minute connection/client timeout to ensure the test fails in time; 1 minute should be plenty. We could do more work to fail immediately (e.g. by moving the client into a separate goroutine and having the main test goroutine wait for either of the client and server), but this seems good enough for an error we don't expect to happen. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtrmac, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
12 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
failing with
Aborting the test from inside a goroutine is invalid; instead, just mark the test as failed, and let the client on the main goroutine time out. By default, that waits too long and the test fails with a generic "timed out" panic, and no record of the cause, so impose a 1-minute connection/client timeout to ensure the test fails in time; 1 minute should be plenty.
We could do more work to fail immediately (e.g. by moving the client into a separate goroutine and having the main test goroutine wait for either of the client and server), but this seems good enough for an error we don't expect to happen.