Random cleanups #150
Random cleanups #150
Conversation
Just use t.TestingDir() now that it is available in Go 1.15, that handles errors and clenup for us automatically. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
It got the meaning of the parameters backwards. Should not change (test) behavior on success. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... per go-staticcheck, and consistent with surrounding code. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... per go-staticcheck (and it also compiles into a tiny bit smaller binary, although that should absolutely not be driving the decision). Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtrmac, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
… noticed while working on other things, or just to silence Visual Studio Code warnings.
See individual commit messages for details.