Bug 1948012: Report the operator status as always upgradeable in serviceCA/cluster #154

mtrmac · 2021-04-10T11:06:39Z

... and this will also, via library-go/pkg/operator/status, show up in ClusterOperators/service-ca , which was previously reporting the default upgradeable Statu: Unknown, Reason: NoData.

https://bugzilla.redhat.com/show_bug.cgi?id=1948012

openshift-ci-robot · 2021-04-10T11:06:43Z

@mtrmac: This pull request references Bugzilla bug 1948012, which is invalid:

expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1948012: Report the operator status as always upgradeable in serviceCA/cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-04-10T11:06:50Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2021-04-10T11:06:55Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mtrmac
To complete the pull request process, please assign sttts after the PR has been reviewed.
You can assign the PR to them by writing /assign @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mtrmac · 2021-04-10T11:07:15Z

/test all

mtrmac · 2021-04-10T13:30:58Z

This trivial implementation is similar to several other operators, and consistent with actual operator behavior (which never stops trying to update the operands).

It might make sense to use library-go/pkg/operator/unsupportedconfigoverridescontroller to block upgrades on unsupported overrides; let me know if I should add that.

mtrmac · 2021-04-10T13:32:39Z

Note: openshift/origin#26030 should be partially dropped after this merges.

wking · 2021-04-10T22:43:13Z

/bugzilla refresh

openshift-ci-robot · 2021-04-10T22:43:19Z

@wking: This pull request references Bugzilla bug 1948012, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @barleyer

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2021-04-10T22:50:07Z

pkg/operator/status.go

+func setUpgradeableTrue(operatorConfig *operatorv1.ServiceCA) {
+	v1helpers.SetOperatorCondition(&operatorConfig.Status.Conditions, operatorv1.OperatorCondition{
+		Type:   operatorv1.OperatorStatusTypeUpgradeable,
+		Status: operatorv1.ConditionTrue,


Can we set Reason: "AsExpected" or some such, because it makes it easier to distinguish between "we're happy" and "oops, we forgot to explain why we were sad" in Telemetry like count by (name,reason) (cluster_operator_conditions)?

Thanks, updated. I couldn’t find a Go constant for "AsExpected", using a string like library-go and others.

hmm, you pass reason into setUpgradeableTrue now (good), but I don't see you actually passing it through to SetOperatorCondition?

Oops, stupid of me. Thanks, hopefully fixed, and I’ll actually test this in practice to confirm this time.

managementState: Managed:

$ oc get serviceca/cluster -o yaml … status: conditions: - lastTransitionTime: "2021-04-14T11:36:15Z" reason: OperatorSyncLoopComplete status: "False" type: Degraded - lastTransitionTime: "2021-04-14T11:44:51Z" message: All service-ca-operator deployments updated reason: ManagedDeploymentsCompleteAndUpdated status: "False" type: Progressing - lastTransitionTime: "2021-04-14T11:44:43Z" reason: ManagedDeploymentsCompleteAndUpdated status: "True" type: Available - lastTransitionTime: "2021-04-14T11:36:15Z" reason: AsExpected status: "True" type: Upgradeable - lastTransitionTime: "2021-04-14T11:36:17Z" status: "False" type: ResourceSyncControllerDegraded … $ oc get clusteroperators/service-ca -o yaml … status: conditions: - lastTransitionTime: "2021-04-14T11:36:10Z" message: All is well reason: AsExpected status: "False" type: Degraded - lastTransitionTime: "2021-04-14T11:44:51Z" message: 'Progressing: All service-ca-operator deployments updated' reason: AsExpected status: "False" type: Progressing - lastTransitionTime: "2021-04-14T11:36:15Z" message: All is well reason: AsExpected status: "True" type: Available - lastTransitionTime: "2021-04-14T11:36:15Z" message: All is well reason: AsExpected status: "True" type: Upgradeable …

and managementState: Unmanaged:

$ oc get serviceca/cluster -o yaml … status: conditions: - lastTransitionTime: "2021-04-14T11:36:15Z" reason: OperatorSyncLoopComplete status: "False" type: Degraded - lastTransitionTime: "2021-04-14T11:44:51Z" message: All service-ca-operator deployments updated reason: ManagedDeploymentsCompleteAndUpdated status: "False" type: Progressing - lastTransitionTime: "2021-04-14T11:44:43Z" reason: ManagedDeploymentsCompleteAndUpdated status: "True" type: Available - lastTransitionTime: "2021-04-14T11:36:15Z" reason: AsExpected status: "True" type: Upgradeable - lastTransitionTime: "2021-04-14T11:36:17Z" status: "False" type: ResourceSyncControllerDegraded … $ oc get clusteroperators/service-ca -o yaml … status: conditions: - lastTransitionTime: "2021-04-14T12:03:47Z" reason: Unmanaged status: Unknown type: Available - lastTransitionTime: "2021-04-14T12:03:47Z" reason: Unmanaged status: Unknown type: Progressing - lastTransitionTime: "2021-04-14T12:03:47Z" reason: Unmanaged status: Unknown type: Degraded - lastTransitionTime: "2021-04-14T12:03:47Z" reason: Unmanaged status: Unknown type: Upgradeable …

mtrmac · 2021-04-12T17:43:06Z

/retest

mtrmac · 2021-04-12T21:43:22Z

/retest

mtrmac · 2021-04-13T20:54:08Z

/retest

... and this will also, via library-go/pkg/operator/status, show up in ClusterOperators/service-ca , which was previously reporting the default upgradeable Statu: Unknown, Reason: NoData. https://bugzilla.redhat.com/show_bug.cgi?id=1948012 Signed-off-by: Miloslav Trmač <mitr@redhat.com>

mtrmac · 2021-04-15T11:02:02Z

/retest

mtrmac · 2021-04-17T12:56:44Z

/retest

stlaz · 2021-05-25T12:17:57Z

/lgtm

openshift-ci · 2021-05-25T12:18:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtrmac, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [stlaz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-05-25T18:37:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-25T19:16:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-05-25T21:11:13Z

@mtrmac: All pull requests linked via external trackers have merged:

openshift/service-ca-operator#154

Bugzilla bug 1948012 has been moved to the MODIFIED state.

In response to this:

Bug 1948012: Report the operator status as always upgradeable in serviceCA/cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Because [1] has landed and [2] is ON_QA. Also for openshift-controller-manager, [3] has landed and [4] is VERIFIED. [1]: openshift/service-ca-operator#154 [2]: https://bugzilla.redhat.com/show_bug.cgi?id=1948012 [3]: openshift/cluster-openshift-controller-manager-operator#210 [4]: https://bugzilla.redhat.com/show_bug.cgi?id=1948011

mtrmac · 2021-05-26T18:12:49Z

Note: openshift/origin#26030 should be partially dropped after this merges.

Happened in openshift/origin#26183 .

mtrmac · 2021-05-31T14:13:58Z

/cherrypick release-4.7

openshift-cherrypick-robot · 2021-05-31T14:14:38Z

@mtrmac: new pull request created: #160

In response to this:

/cherrypick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from marun and stlaz April 10, 2021 11:06

mtrmac marked this pull request as ready for review April 10, 2021 13:31

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2021

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 10, 2021

openshift-ci-robot requested a review from barleyer April 10, 2021 22:43

wking reviewed Apr 10, 2021

View reviewed changes

mtrmac force-pushed the upgradeable branch from ea1981e to 1c537a1 Compare April 12, 2021 12:33

mtrmac force-pushed the upgradeable branch from 1c537a1 to 567d580 Compare April 14, 2021 11:17

openshift-ci bot assigned stlaz May 25, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2021

openshift-merge-robot merged commit 91b4991 into openshift:master May 25, 2021

wking mentioned this pull request May 25, 2021

Bug 1948012: test/extended/operators: Drop service-ca Upgradeable exception openshift/origin#26183

Merged

mtrmac deleted the upgradeable branch May 26, 2021 10:23

openshift-ci bot mentioned this pull request May 27, 2021

Bug 1948012: Revert "test/extended/operators: Drop service-ca Upgradeable exception" openshift/origin#26189

Merged

openshift-cherrypick-robot mentioned this pull request May 31, 2021

[release-4.7] Bug 1966148: Report the operator status as always upgradeable in serviceCA/cluster #160

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1948012: Report the operator status as always upgradeable in serviceCA/cluster #154

Bug 1948012: Report the operator status as always upgradeable in serviceCA/cluster #154

mtrmac commented Apr 10, 2021

openshift-ci-robot commented Apr 10, 2021

openshift-ci-robot commented Apr 10, 2021

openshift-ci-robot commented Apr 10, 2021

mtrmac commented Apr 10, 2021

mtrmac commented Apr 10, 2021

mtrmac commented Apr 10, 2021

wking commented Apr 10, 2021

openshift-ci-robot commented Apr 10, 2021

wking Apr 10, 2021

mtrmac Apr 12, 2021

wking Apr 14, 2021

mtrmac Apr 14, 2021

mtrmac Apr 14, 2021

mtrmac commented Apr 12, 2021

mtrmac commented Apr 12, 2021

mtrmac commented Apr 13, 2021

mtrmac commented Apr 15, 2021

mtrmac commented Apr 17, 2021

stlaz commented May 25, 2021

openshift-ci bot commented May 25, 2021

openshift-bot commented May 25, 2021

openshift-bot commented May 25, 2021

openshift-ci bot commented May 25, 2021

mtrmac commented May 26, 2021

mtrmac commented May 31, 2021

openshift-cherrypick-robot commented May 31, 2021

Bug 1948012: Report the operator status as always upgradeable in serviceCA/cluster #154

Bug 1948012: Report the operator status as always upgradeable in serviceCA/cluster #154

Conversation

mtrmac commented Apr 10, 2021

openshift-ci-robot commented Apr 10, 2021

openshift-ci-robot commented Apr 10, 2021

openshift-ci-robot commented Apr 10, 2021

mtrmac commented Apr 10, 2021

mtrmac commented Apr 10, 2021

mtrmac commented Apr 10, 2021

wking commented Apr 10, 2021

openshift-ci-robot commented Apr 10, 2021

wking Apr 10, 2021

Choose a reason for hiding this comment

mtrmac Apr 12, 2021

Choose a reason for hiding this comment

wking Apr 14, 2021

Choose a reason for hiding this comment

mtrmac Apr 14, 2021

Choose a reason for hiding this comment

mtrmac Apr 14, 2021

Choose a reason for hiding this comment

mtrmac commented Apr 12, 2021

mtrmac commented Apr 12, 2021

mtrmac commented Apr 13, 2021

mtrmac commented Apr 15, 2021

mtrmac commented Apr 17, 2021

stlaz commented May 25, 2021

openshift-ci bot commented May 25, 2021

openshift-bot commented May 25, 2021

openshift-bot commented May 25, 2021

openshift-ci bot commented May 25, 2021

mtrmac commented May 26, 2021

mtrmac commented May 31, 2021

openshift-cherrypick-robot commented May 31, 2021