Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2034484: feat: library-go bump #185

Merged
merged 4 commits into from
Jan 3, 2022
Merged

Bug 2034484: feat: library-go bump #185

merged 4 commits into from
Jan 3, 2022

Conversation

qJkee
Copy link
Contributor

@qJkee qJkee commented Dec 9, 2021 •
edited
Loading

Bumping the library-go dependency to latest, this should take advantage of leader election changes for SNO clusters proposed in this library-go PR and performance improvements in this PR.

It also includes the following BZ bug fix
Bug 2034484: fix:library-go nil pointer issue

@openshift-ci openshift-ci bot requested review from deads2k and stlaz December 9, 2021 15:46
@qJkee
Copy link
Contributor Author

qJkee commented Dec 9, 2021

/retest

@qJkee qJkee changed the title Upgrade library-go version WIP:Upgrade library-go version Dec 9, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2021
@qJkee qJkee marked this pull request as draft December 9, 2021 17:35
@qJkee qJkee marked this pull request as ready for review December 13, 2021 18:38
@qJkee qJkee changed the title WIP:Upgrade library-go version [WIP] Upgrade library-go version Dec 13, 2021
@stlaz
Copy link
Contributor

stlaz commented Dec 14, 2021

Please move any changes done outside the vendoring to a separate commit.

@qJkee qJkee force-pushed the CNF-3684-deps branch 2 times, most recently from bf654f7 to 9d3bf6a Compare December 14, 2021 20:39
@qJkee
Copy link
Contributor Author

qJkee commented Dec 15, 2021

/retest-required

@jerpeter1
Copy link
Member

/retest-required

1 similar comment
@jerpeter1
Copy link
Member

/retest-required

@jerpeter1
Copy link
Member

/test e2e-aws-operator

5 similar comments
@jerpeter1
Copy link
Member

/test e2e-aws-operator

@jerpeter1
Copy link
Member

/test e2e-aws-operator

@jerpeter1
Copy link
Member

/test e2e-aws-operator

@jerpeter1
Copy link
Member

/test e2e-aws-operator

@jerpeter1
Copy link
Member

/test e2e-aws-operator

@qJkee qJkee force-pushed the CNF-3684-deps branch 2 times, most recently from 5415c57 to 6d8927a Compare December 17, 2021 16:33
@qJkee qJkee force-pushed the CNF-3684-deps branch 3 times, most recently from 9465f82 to d1a7d50 Compare December 21, 2021 14:27
@qJkee
Copy link
Contributor Author

qJkee commented Dec 21, 2021

/retest-required

1 similar comment
@jerpeter1
Copy link
Member

/retest-required

@qJkee qJkee changed the title [WIP] Upgrade library-go version Upgrade library-go version Dec 22, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 22, 2021
stlaz
stlaz suggested changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@stlaz stlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please separate the changes to separate commits and explain them

bindata/v4.0.0/controller/clusterrole.yaml
Comment on lines +65 to +72
- apiGroups:
- config.openshift.io
resources:
- infrastructures
verbs:
- get
- list
- watch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate commit, explain in commit message please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

89f04d8

cmd/service-ca-operator/main.go Outdated
@@ -23,6 +23,7 @@ func main() {
pflag.CommandLine.SetNormalizeFunc(utilflag.WordSepNormalizeFunc)
pflag.CommandLine.AddGoFlagSet(goflag.CommandLine)

logs.AddFlags(pflag.CommandLine)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate commit, fix like this: openshift/cluster-authentication-operator@a2f0d1f

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

85ccd9a

pkg/operator/operator.go Outdated
@@ -106,7 +106,7 @@ func (c *serviceCAOperator) Sync(ctx context.Context, syncCtx factory.SyncContex
}

func (c serviceCAOperator) updateStatus(operatorConfig *operatorv1.ServiceCA) {
v1helpers.UpdateStatus(c.operatorClient, func(status *operatorv1.OperatorStatus) error {
v1helpers.UpdateStatus(context.TODO(), c.operatorClient, func(status *operatorv1.OperatorStatus) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wire the context properly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bb03417

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 24, 2021

@qJkee: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stlaz
Copy link
Contributor

stlaz commented Jan 3, 2022

/lgtm
thank you for your PR 👍

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qJkee, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2022
@ggiguash
Copy link

ggiguash commented Jan 3, 2022

/retitle Bug 2034484: feat: library-go bump

@openshift-ci openshift-ci bot changed the title Upgrade library-go version Bug 2034484: feat: library-go bump Jan 3, 2022
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jan 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2022

@qJkee: This pull request references Bugzilla bug 2034484, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (jhou@redhat.com), skipping review request.

In response to this:

Bug 2034484: feat: library-go bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 3, 2022
@openshift-merge-robot openshift-merge-robot merged commit 1611373 into openshift:master Jan 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2022

@qJkee: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2034484 has not been moved to the MODIFIED state.

In response to this:

Bug 2034484: feat: library-go bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-service-ca-operator-container-v4.10.0-202305011254.p0.g1611373.assembly.stream for distgit ose-service-ca-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlaz stlaz stlaz approved these changes

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@stlaz stlaz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@qJkee @stlaz @jerpeter1 @ggiguash @openshift-bot @openshift-merge-robot