OCPBUGS-8512: fix admission webhook CA injection #219
Conversation
openshift-ci-robot
added
jira/severity-important
|
@stlaz: This pull request references Jira Issue OCPBUGS-8512, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
| webhookConfigType: "mutatingwebhookconfiguration", | ||
| client: config.kubeClient.AdmissionregistrationV1().MutatingWebhookConfigurations(), | ||
| lister: informer.Lister(), | ||
| webhookConfigAccessorInit: newMutatingWebhookAccessor, |
There was a problem hiding this comment.
let's call this newWebhookAccessor, this naming provides a nice abstraction to the concrete implementations newMutatingWebhookAccessor and newValidatingWebhookAccessor.
There was a problem hiding this comment.
note: initialization is different from construction and usually comes after it.
stlaz
force-pushed
the
admission_webhooks
branch
from
86d1aca
to
5ef0f69
Compare
|
/lgtm |
…ok of the config object Also unifies the logic for bundleinjectors using go generics.
stlaz
force-pushed
the
admission_webhooks
branch
from
5ef0f69
to
17d1995
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: s-urbaniak, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/jira refresh |
|
@stlaz: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
jira/valid-bug
|
@stlaz: This pull request references Jira Issue OCPBUGS-8512, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
1 similar comment
|
/retest-required |
|
@stlaz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@stlaz: Jira Issue OCPBUGS-8512: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-8512 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@stlaz: new pull request created: #222 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR fixes the problem outlined in #207. It unifies the webhook injectors logic and uses the original PR bits for the e2e tests.