API-1673: Add description annotations to service CA secret and configmap #225
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
dinhxuanvu
force-pushed
the
cert-description
branch
2 times, most recently
from
19600fd
to
2d3d8cf
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
dinhxuanvu
force-pushed
the
cert-description
branch
2 times, most recently
from
edc7c2b
to
b143757
Compare
dinhxuanvu
force-pushed
the
cert-description
branch
from
b143757
to
a0fba4c
Compare
pkg/controller/servingcert/controller/secret_creating_controller.go
Outdated
Show resolved
Hide resolved
dinhxuanvu
force-pushed
the
cert-description
branch
from
a0fba4c
to
8d54832
Compare
|
/retest |
pkg/controller/servingcert/controller/secret_creating_controller.go
Outdated
Show resolved
Hide resolved
|
configmaps with injected CA bundles need descriptions (if not present) too. They should describe what sorts of certificates they can be used to verify. |
dinhxuanvu
force-pushed
the
cert-description
branch
2 times, most recently
from
d7fd721
to
6a6ba04
Compare
|
/retest |
1 similar comment
|
/retest |
|
@deads2k PTAL. Thanks |
pkg/controller/servingcert/controller/secret_creating_controller.go
Outdated
Show resolved
Hide resolved
pkg/controller/servingcert/controller/secret_updating_controller.go
Outdated
Show resolved
Hide resolved
dinhxuanvu
force-pushed
the
cert-description
branch
2 times, most recently
from
c9bab5a
to
5c0ebfe
Compare
|
/lgtm |
openshift-ci
bot
added
the
approved
dinhxuanvu
force-pushed
the
cert-description
branch
from
5c0ebfe
to
d52774d
Compare
Service CA generates a secret and configmap for its signing key. These secret and configmap need to have description annotation to conform to the new cert ownership validation. For all secrets that are created by service CA for services, an ownership and description annotations are generated to indicate service CA owns these secrets and its corresponding service owner. Signed-off-by: Vu Dinh <vudinh@outlook.com>
dinhxuanvu
force-pushed
the
cert-description
branch
from
d52774d
to
f24c4b0
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, dinhxuanvu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dinhxuanvu: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
dinhxuanvu
changed the title
|
@dinhxuanvu: This pull request references API-1673 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-service-ca-operator-container-v4.15.0-202312010209.p0.g4d3d966.assembly.stream for distgit ose-service-ca-operator. |
Service CA generates a secret and configmap for its signing key.
These secret and configmap need to have description annotation
to conform to the new cert ownership validation.
For all secrets that are created by service CA for services, an
ownership and description annotations are generated to indicate
service CA owns these secrets and its corresponding service owner.
Signed-off-by: Vu Dinh vudinh@outlook.com