Add status back to spec subresource #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
|
/lgtm |
When service-ca client tries to update our status, it does that via subresource but the fact that status is the CR's subresource got unfortunately removed. Add it back.
openshift-ci-robot
added
size/XXL
|
Adds a bump, all status fields were made optional in the meantime, we were trying to have |
…penshift/api/operator/v1
Adds version from current operator image to the clusteroperator, if and only if the managed deployments are available and ready, and there are no replicas left from previous versions. Also, adds operator status available if deployments, replicas exist.
|
Pushed changes from #34 on top so that we eventually report as |
|
/lgtm |
Closed
|
/test unit |
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-aws |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When service-ca client tries to update our status, it does that via
subresource but the fact that status is the CR's subresource got
unfortunately removed. Add it back.
I believe this should get rid of the log spam.