Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary permissions for controllers #97

Merged
merged 2 commits into from Jan 23, 2020
Merged

Remove unnecessary permissions for controllers #97

merged 2 commits into from Jan 23, 2020

Conversation

marun
Copy link
Contributor

@marun marun commented Jan 21, 2020

The controller unification PR added permissions for removing 4.3 resources to the role used by controllers but removal will be performed by the operator which has cluster admin privileges.

/cc @stlaz

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 21, 2020
@marun
Remove unnecessary permissions for controllers
48bd33b 
The controller unification PR added permissions for removing 4.3
resources to the role used by controllers but removal will be
performed by the operator which has cluster admin privileges.
@marun
Update bindata
64a70b9
@marun
Copy link
Contributor Author

marun commented Jan 22, 2020

Rebased

@stlaz
Copy link
Member

stlaz commented Jan 22, 2020

/lgtm
I should have noticed that when I pointed out the perms weren't enough to remove the deployment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@marun
Copy link
Contributor Author

marun commented Jan 22, 2020

/retest

2 similar comments
@marun
Copy link
Contributor Author

marun commented Jan 23, 2020

/retest

@marun
Copy link
Contributor Author

marun commented Jan 23, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 10f9391 into openshift:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlaz stlaz Awaiting requested review from stlaz

Assignees

@stlaz stlaz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marun @stlaz @openshift-ci-robot @openshift-bot @openshift-merge-robot