organize job run results by job #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparees
reviewed
Sep 8, 2020
main.go
Outdated
| } | ||
| } | ||
|
|
||
| func getFailedTestNamesFromJobRuns(jobRuns map[string]testgridanalysisapi.RawJobRunResult) sets.String { | ||
| func getFailedTestNamesFromJobRuns(jobResults map[string]testgridanalysisapi.RawJobResult) sets.String { |
There was a problem hiding this comment.
Suggested change
| func getFailedTestNamesFromJobRuns(jobResults map[string]testgridanalysisapi.RawJobResult) sets.String { | |
| func getFailedTestNamesFromJobResults(jobResults map[string]testgridanalysisapi.RawJobResult) sets.String { |
pkg/util/utils.go
Outdated
| bzComponentToBZJobResults := map[string][]sippyprocessingv1.BugzillaJobResult{} | ||
| for job, jobRunResults := range jobRunsByJob { | ||
| curr := generateJobFailuresByBugzillaComponent(job, jobRunResults, jobToTestResults[job].TestResults) | ||
| for job, jobRunResult := range allJobResults { |
There was a problem hiding this comment.
Suggested change
| for job, jobRunResult := range allJobResults { | |
| for job, jobResult := range allJobResults { |
?
deads2k
force-pushed
the
refactor-raw-jobs-by-job
branch
from
159c425
to
98d043d
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This presentation is more what people expect and simplifies some logic of the processing and transformation. It also gets us ready for building out test results by job and unifying aggregration types.