Bug 2060007: Makefile fixes for: no rule 'docker-push' #122

ukalifon · 2022-03-01T12:45:24Z

Remove calls to target docker-push, which doesn't exist

openshift-ci · 2022-03-01T12:45:25Z

@ukalifon: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-03-01T12:46:04Z

Hi @ukalifon. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pacevedom · 2022-03-01T13:17:45Z

Not sure, but are we allowed to push to 4.10 without a BZ?

qbarrand · 2022-03-01T15:25:16Z

Yes, I would first merge this into master, then cherry-picked into the release branch if possible.
Also, could we merge this change upstream first?

Remove calls to target docker-push, which doesn't exist

ukalifon · 2022-03-02T06:48:45Z

@qbarrand @yevgeny-shnaidman It doesn't make sense to merge this into master first, because the Makefile there is vastly different from this one, and in master the container command is parameterized. So instead, I fixed my PR to have the container command parameterized in this branch as well, pretty similar to how it is in master.

qbarrand · 2022-03-02T09:15:43Z

I would still merge this into master, then cherry-pick the commit in here, adding CONTAINER_COMMAND setup and other fixes as necessary (like you did here).
Release branches are always started off from master, so if we only fix this release branch, we'll be facing the same problem in 4.11, 4.12 and so on.

qbarrand · 2022-03-02T09:28:05Z

/ok-to-test

qbarrand · 2022-03-02T09:47:38Z

/lgtm
/approve

ukalifon · 2022-03-02T14:09:19Z

BZ is here: https://bugzilla.redhat.com/show_bug.cgi?id=2060007

qbarrand · 2022-03-02T14:50:21Z

@ukalifon please prepend the PR's title with Bug 2060007: and then comment /bugzilla refresh.

openshift-ci · 2022-03-03T06:01:22Z

@ukalifon: This pull request references Bugzilla bug 2060007, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead
expected Bugzilla bug 2060007 to depend on a bug targeting a release in 4.11.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ukalifon · 2022-03-03T06:01:48Z

/bugzilla refresh

openshift-ci · 2022-03-03T06:01:51Z

@ukalifon: This pull request references Bugzilla bug 2060007, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead
expected Bugzilla bug 2060007 to depend on a bug targeting a release in 4.11.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qbarrand · 2022-03-03T07:49:35Z

/bugzilla refresh

openshift-ci · 2022-03-03T07:49:38Z

@qbarrand: This pull request references Bugzilla bug 2060007, which is invalid:

expected Bugzilla bug 2060007 to depend on a bug targeting a release in 4.11.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ukalifon · 2022-03-03T07:57:40Z

/bugzilla refresh

openshift-ci · 2022-03-20T01:01:29Z

@openshift-bot: This pull request references Bugzilla bug 2060007, which is invalid:

expected the bug to target the "4.10.z" release, but it targets "---" instead
expected Bugzilla bug 2060007 to depend on a bug targeting a release in 4.11.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-03-21T01:01:21Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-21T01:01:33Z

@openshift-bot: This pull request references Bugzilla bug 2060007, which is invalid:

expected the bug to target the "4.10.z" release, but it targets "---" instead
expected Bugzilla bug 2060007 to depend on a bug targeting a release in 4.11.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bthurber · 2022-03-21T23:44:18Z

/bugzilla refresh

openshift-ci · 2022-03-21T23:44:21Z

@bthurber: This pull request references Bugzilla bug 2060007, which is invalid:

expected the bug to target the "4.10.z" release, but it targets "4.11.0" instead
expected Bugzilla bug 2060007 to depend on a bug targeting a release in 4.11.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-03-22T01:01:11Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-22T01:01:22Z

@openshift-bot: This pull request references Bugzilla bug 2060007, which is invalid:

expected the bug to target the "4.10.z" release, but it targets "4.11.0" instead
expected Bugzilla bug 2060007 to depend on a bug targeting a release in 4.11.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bthurber · 2022-03-22T19:10:08Z

/bugzilla refresh

openshift-ci · 2022-03-22T19:10:11Z

@bthurber: This pull request references Bugzilla bug 2060007, which is invalid:

expected the bug to target the "4.10.z" release, but it targets "4.11.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead
expected Bugzilla bug 2060007 to depend on a bug targeting a release in 4.11.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bthurber · 2022-03-22T19:16:03Z

/bugzilla refresh

openshift-ci · 2022-03-22T19:16:10Z

@bthurber: This pull request references Bugzilla bug 2060007, which is invalid:

expected dependent Bugzilla bug 2066923 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bthurber · 2022-03-22T19:19:06Z

/bugzilla refresh

openshift-ci · 2022-03-22T19:19:25Z

@bthurber: This pull request references Bugzilla bug 2060007, which is invalid:

expected Bugzilla bug 2060007 to depend on a bug targeting a release in 4.11.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bthurber · 2022-03-22T19:22:37Z

/bugzilla refresh

openshift-ci · 2022-03-22T19:22:40Z

@bthurber: This pull request references Bugzilla bug 2060007, which is invalid:

expected Bugzilla bug 2060007 to depend on a bug targeting a release in 4.11.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bthurber · 2022-03-22T19:25:08Z

/bugzilla refresh

openshift-ci · 2022-03-22T19:25:15Z

@bthurber: This pull request references Bugzilla bug 2060007, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.z) matches configured target release for branch (4.10.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2066923 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2066923 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ukalifon@redhat.com), skipping review request.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bthurber · 2022-03-22T19:34:39Z

/lgtm

bthurber · 2022-03-22T19:37:01Z

/approve

openshift-ci · 2022-03-22T19:37:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bthurber, qbarrand, ukalifon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [bthurber,qbarrand]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bthurber · 2022-03-22T19:44:49Z

/label backport-risk-assessed

wabouhamad · 2022-03-23T03:54:56Z

/label cherry-pick-approved

openshift-ci · 2022-03-23T07:21:17Z

@ukalifon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-03-23T09:46:23Z

@ukalifon: All pull requests linked via external trackers have merged:

openshift/special-resource-operator#122

Bugzilla bug 2060007 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from qbarrand and yevgeny-shnaidman March 1, 2022 12:46

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 1, 2022

ukalifon mentioned this pull request Mar 1, 2022

Makefile fixes for: no rule 'docker-push' #121

Closed

Makefile fixes for: no rule 'docker-push'

36e0c22

Remove calls to target docker-push, which doesn't exist

ukalifon force-pushed the fix_docker_push branch from eee2258 to 36e0c22 Compare March 2, 2022 06:41

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 2, 2022

openshift-ci bot assigned qbarrand Mar 2, 2022

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 2, 2022

ukalifon changed the title ~~Makefile fixes for: no rule 'docker-push'~~ Bug 2060007: Makefile fixes for: no rule 'docker-push' Mar 3, 2022

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 3, 2022

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 22, 2022

openshift-ci bot assigned bthurber Mar 22, 2022

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 22, 2022

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 23, 2022

openshift-merge-robot merged commit e3d40ae into openshift:release-4.10 Mar 23, 2022

Bug 2060007: Makefile fixes for: no rule 'docker-push' #122

Bug 2060007: Makefile fixes for: no rule 'docker-push' #122

Conversation

ukalifon commented Mar 1, 2022

openshift-ci bot commented Mar 1, 2022

openshift-ci bot commented Mar 1, 2022

pacevedom commented Mar 1, 2022

qbarrand commented Mar 1, 2022

ukalifon commented Mar 2, 2022

qbarrand commented Mar 2, 2022

qbarrand commented Mar 2, 2022

qbarrand commented Mar 2, 2022

ukalifon commented Mar 2, 2022

qbarrand commented Mar 2, 2022 • edited

openshift-ci bot commented Mar 3, 2022

ukalifon commented Mar 3, 2022

openshift-ci bot commented Mar 3, 2022

qbarrand commented Mar 3, 2022

openshift-ci bot commented Mar 3, 2022

ukalifon commented Mar 3, 2022

openshift-ci bot commented Mar 20, 2022

openshift-bot commented Mar 21, 2022

openshift-ci bot commented Mar 21, 2022

bthurber commented Mar 21, 2022

openshift-ci bot commented Mar 21, 2022

openshift-bot commented Mar 22, 2022

openshift-ci bot commented Mar 22, 2022

bthurber commented Mar 22, 2022

openshift-ci bot commented Mar 22, 2022

bthurber commented Mar 22, 2022

openshift-ci bot commented Mar 22, 2022

bthurber commented Mar 22, 2022

openshift-ci bot commented Mar 22, 2022

bthurber commented Mar 22, 2022

openshift-ci bot commented Mar 22, 2022

bthurber commented Mar 22, 2022

openshift-ci bot commented Mar 22, 2022

bthurber commented Mar 22, 2022

bthurber commented Mar 22, 2022

openshift-ci bot commented Mar 22, 2022

bthurber commented Mar 22, 2022

wabouhamad commented Mar 23, 2022

openshift-ci bot commented Mar 23, 2022

openshift-ci bot commented Mar 23, 2022

qbarrand commented Mar 2, 2022 •

edited