Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1986174: SRO should be able to read a complete chart form a ConfigMap. #24

Merged
merged 2 commits into from Jul 26, 2021

Conversation

dagrayvid
Copy link
Contributor

This PR is a cherry-pick of the upstream fix to the referenced bug. From the BZ:

Description of problem:

For debugging and local development we introduced a ConfigMap to override specific states in the deployed chart. Some customers that do not want to package charts in SRO or push the charts to a HTTP registry want an easy way to deploy charts locally.

SRO should be able to read a complete chart form a ConfigMap.

Zvonko Kaiser and others added 2 commits July 26, 2021 16:52
* Added full chart support as override

* Added nodeSelector and kernel affine settings to Deployment and Statefulset

* Wait for ping-pong CRD deletion in e2e-test, fix bugs related to vanilla-k8s checks

* Added updated docs for debugging

Co-authored-by: David Gray <dagray@redhat.com>
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 26, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 26, 2021

@dagrayvid: This pull request references Bugzilla bug 1986174, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wabouhamad

In response to this:

Bug 1986174: SRO should be able to read a complete chart form a ConfigMap.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dagrayvid
Copy link
Contributor Author

/assign @zvonkok

@zvonkok
Copy link
Contributor

zvonkok commented Jul 26, 2021

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dagrayvid, zvonkok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2021
@openshift-merge-robot openshift-merge-robot merged commit 7514ac0 into openshift:master Jul 26, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 26, 2021

@dagrayvid: All pull requests linked via external trackers have merged:

Bugzilla bug 1986174 has been moved to the MODIFIED state.

In response to this:

Bug 1986174: SRO should be able to read a complete chart form a ConfigMap.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants