Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.9] Bug 2009530: poll.go Deployment availability bug fix and Veritas SpecialResource fixes #39

Merged

Conversation

pacevedom
Copy link
Contributor

…ialResource fixes (#38)

Signed-off-by: Pablo Acevedo Montserrat pacevedo@redhat.com

Signed-off-by: Pablo Acevedo Montserrat pacevedo@redhat.com

Signed-off-by: David Gray dagray@redhat.com

  • Infoscale fencing afterhook and other enhancements (Remove the lustre chart #99)

  • Adding fencing afterhook podtemplate
    Rbac changes for fencing afterhook

  • Added secret to support DNS resource

  • Update bundle and manifests

Co-authored-by: Trishnendu trishnendu.ghorai@veritas.com
Co-authored-by: David Gray dagray@redhat.com

Co-authored-by: David Gray 40244437+dagrayvid@users.noreply.github.com
Co-authored-by: Veritas Technologies LLC opensource@veritas.com
Co-authored-by: Trishnendu trishnendu.ghorai@veritas.com
Co-authored-by: David Gray dagray@redhat.com

…ialResource fixes (openshift-psap#38)

* Add preamble creation to e2e test (openshift-psap#95)

Signed-off-by: Pablo Acevedo Montserrat <pacevedo@redhat.com>

* Fix ReplicaSet upgrade checks (openshift-psap#98)

Signed-off-by: Pablo Acevedo Montserrat <pacevedo@redhat.com>

* Add bthurber, ybettan, yevgeny-shnaidman to OWNERS (openshift-psap#100)

Signed-off-by: David Gray <dagray@redhat.com>

* Infoscale fencing afterhook and other enhancements (openshift-psap#99)

* Adding fencing afterhook podtemplate
Rbac changes for fencing afterhook

* Added secret to support DNS resource

* Update bundle and manifests

Co-authored-by: Trishnendu <trishnendu.ghorai@veritas.com>
Co-authored-by: David Gray <dagray@redhat.com>

Co-authored-by: David Gray <40244437+dagrayvid@users.noreply.github.com>
Co-authored-by: Veritas Technologies LLC <opensource@veritas.com>
Co-authored-by: Trishnendu <trishnendu.ghorai@veritas.com>
Co-authored-by: David Gray <dagray@redhat.com>
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 30, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2021

@pacevedom: This pull request references Bugzilla bug 2009424, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "4.10.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected Bugzilla bug 2009424 to depend on a bug targeting a release in 4.10.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2009424: poll.go Deployment availability bug fix and Veritas SpecialResource fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 30, 2021
@pacevedom pacevedom changed the title Bug 2009424: poll.go Deployment availability bug fix and Veritas SpecialResource fixes poll.go Deployment availability bug fix and Veritas SpecialResource fixes Sep 30, 2021
@openshift-ci openshift-ci bot removed the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 30, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2021

@pacevedom: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

poll.go Deployment availability bug fix and Veritas SpecialResource fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 30, 2021
@dagrayvid
Copy link
Contributor

/retitle [release-4.9] Bug 2009530: poll.go Deployment availability bug fix and Veritas SpecialResource fixes

@openshift-ci openshift-ci bot changed the title poll.go Deployment availability bug fix and Veritas SpecialResource fixes [release-4.9] Bug 2009530: poll.go Deployment availability bug fix and Veritas SpecialResource fixes Sep 30, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 30, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2021

@pacevedom: This pull request references Bugzilla bug 2009530, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2009424 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2009424 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

Requesting review from QA contact:
/cc @wabouhamad

In response to this:

[release-4.9] Bug 2009530: poll.go Deployment availability bug fix and Veritas SpecialResource fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dagrayvid
Copy link
Contributor

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2021

@dagrayvid: This pull request references Bugzilla bug 2009530, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2009424 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2009424 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

Requesting review from QA contact:
/cc @wabouhamad

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dagrayvid
Copy link
Contributor

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dagrayvid, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 30, 2021
@openshift-merge-robot openshift-merge-robot merged commit 3b5e7d4 into openshift:release-4.9 Sep 30, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2021

@pacevedom: All pull requests linked via external trackers have merged:

Bugzilla bug 2009530 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2009530: poll.go Deployment availability bug fix and Veritas SpecialResource fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants