Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-2287: Add feature "Announce IP on pod creation" #49

Merged
merged 3 commits into from
Nov 11, 2022
Merged

OCPBUGS-2287: Add feature "Announce IP on pod creation" #49

merged 3 commits into from
Nov 11, 2022

Commits on Oct 13, 2022

  1. Use "os" package for creating directories instead of "ioutil" 

    Original Cherry-Pick 1979e39:
	Fix golint issue

	Signed-off-by: Sebastian Sch <sebassch@gmail.com>

This commit does not change the golangci-lint version.

Signed-off-by: William Zhao <wizhao@redhat.com>
    @SchSeba @wizhaoredhat
    SchSeba authored and wizhaoredhat committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    c3906a9 View commit details
    Browse the repository at this point in the history

  2. Send IPv4 GARP and IPv6 Unsolicited NA in "cmdAdd" 

    In "cmdAdd", SRIOV-CNI would construct and send IPv4 Gratuitous ARP
and/or Unsolicited Neighbor Advertisement depending on the IP
addresses configured by IPAM. The reason why this change is needed
is for the scenario when an IP address is reused by IPAM with
different interfaces (with different link-layer addresses). This can
occur when pods are deleted and created. For performance reasons,
sending of GARP and/or Unsolicited NA would update invalid ARP/Neighbor
caches in other neighbors/nodes.

Also we set IPv4 ARP Notify and IPv6 Neighbor Discovery Notify in sysfs
for each interface. This will send GARP and/or Unsolicited NA when the
interface is either brought up or the link-layer address changes. This
is useful in cases where an application reenables the interface or the
MAC address configuration is changed.

Some new packages were added, thus go.mod and go.sum were modified
accordingly.

Mocked PciUtils for sriov tests since sriov.go would call PciUtils to
set IPv4 ARP Notify and IPv6 Neighbor Discovery.

Fixes k8snetworkplumbingwg#177

Signed-off-by: William Zhao <wizhao@redhat.com>
    @wizhaoredhat
    wizhaoredhat committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    fac0d9f View commit details
    Browse the repository at this point in the history

  3. Update "go mod vendor", go.mod and go.sum 

    For the commit: bb013da
Vendor packages were updated/added.

Signed-off-by: William Zhao <wizhao@redhat.com>
    @wizhaoredhat
    wizhaoredhat committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    d8f7849 View commit details
    Browse the repository at this point in the history