Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.11] OCPBUGS-4603: Add pci address lock for allocated devices (#220) #60

Merged
merged 1 commit into from May 8, 2023
Merged

[release-4.11] OCPBUGS-4603: Add pci address lock for allocated devices (#220) #60

merged 1 commit into from May 8, 2023

Conversation

cgoncalves
Copy link
Contributor

  • Create allocation interface and implementation. This is needed to lock the allocation of the same PCI address until the cmdDel is called or the kernel remove the network namespace.

Signed-off-by: Sebastian Sch sebassch@gmail.com

  • Use the allocator interface to prevent allocation of still in used pci addresses

Fixes: k8snetworkplumbingwg/sriov-cni#219

Signed-off-by: Sebastian Sch sebassch@gmail.com

Signed-off-by: Sebastian Sch sebassch@gmail.com

@SchSeba @cgoncalves
Add pci address lock for allocated devices (#220)
26041d9 
* Create allocation interface and implementation.
This is needed to lock the allocation of the same PCI address until the cmdDel is called or the kernel remove the network namespace.

Signed-off-by: Sebastian Sch <sebassch@gmail.com>

* Use the allocator interface to prevent allocation of still in used pci addresses

Fixes: k8snetworkplumbingwg/sriov-cni#219

Signed-off-by: Sebastian Sch <sebassch@gmail.com>

Signed-off-by: Sebastian Sch <sebassch@gmail.com>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 8, 2023
@openshift-ci-robot
Copy link
Contributor

@cgoncalves: This pull request references Jira Issue OCPBUGS-4603, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-4585 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-4585 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0, 4.12.z
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • Create allocation interface and implementation. This is needed to lock the allocation of the same PCI address until the cmdDel is called or the kernel remove the network namespace.

Signed-off-by: Sebastian Sch sebassch@gmail.com

  • Use the allocator interface to prevent allocation of still in used pci addresses

Fixes: k8snetworkplumbingwg/sriov-cni#219

Signed-off-by: Sebastian Sch sebassch@gmail.com

Signed-off-by: Sebastian Sch sebassch@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgoncalves cgoncalves mentioned this pull request Feb 8, 2023
Closed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2023

@cgoncalves: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to this:

[release-4.11] OCPBUGS-4603: Add pci address lock for allocated devices (#220)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from bn222 and dcbw February 8, 2023 13:40
@cgoncalves
Copy link
Contributor Author

/retest-required

@zeeke
Copy link
Contributor

zeeke commented Mar 13, 2023

/lgtm
/backport-risk-assessed
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2023
@zeeke
Copy link
Contributor

zeeke commented Mar 13, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 13, 2023
@cgoncalves
Copy link
Contributor Author

@evgenLevin please review

@evgenLevin
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 24, 2023
@cgoncalves
Copy link
Contributor Author

@SchSeba could you please review and approve?

@cgoncalves
Copy link
Contributor Author

@zshi-redhat could you please review and approve?

@SchSeba
Copy link
Contributor

SchSeba commented Apr 27, 2023

/lgtm
/approve

@cgoncalves
Copy link
Contributor Author

@zshi-redhat @dougbtv @bn222 could you please approve this PR?

@bn222
Copy link
Contributor

bn222 commented May 8, 2023

/lgtm
/approve

This fix might address a few bugs we've had.

@zhaozhanqi as an FYI. This is going in.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bn222, cgoncalves, SchSeba, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2023

@cgoncalves: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 71764f5 into openshift:release-4.11 May 8, 2023
3 checks passed
@openshift-ci-robot
Copy link
Contributor

@cgoncalves: Jira Issue OCPBUGS-4603: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4603 has been moved to the MODIFIED state.

In response to this:

  • Create allocation interface and implementation. This is needed to lock the allocation of the same PCI address until the cmdDel is called or the kernel remove the network namespace.

Signed-off-by: Sebastian Sch sebassch@gmail.com

  • Use the allocator interface to prevent allocation of still in used pci addresses

Fixes: k8snetworkplumbingwg/sriov-cni#219

Signed-off-by: Sebastian Sch sebassch@gmail.com

Signed-off-by: Sebastian Sch sebassch@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build sriov-cni-container-v4.11.0-202311211130.p0.g71764f5.assembly.stream for distgit sriov-cni.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

@bn222 bn222 Awaiting requested review from bn222

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@zeeke zeeke

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet