Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG 1770709: Use "preserveUnknownFields: false" for the CRD #119

Merged
merged 2 commits into from Nov 12, 2019
Merged

BUG 1770709: Use "preserveUnknownFields: false" for the CRD #119

merged 2 commits into from Nov 12, 2019

Conversation

pliurh
Copy link
Contributor

@pliurh pliurh commented Nov 11, 2019

No description provided.

zshi-redhat
zshi-redhat reviewed Nov 11, 2019
View reviewed changes
Makefile Outdated
@@ -102,3 +102,13 @@ else
endif

verify: verify-gofmt

sync-manifests:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may not work for 4.3 if there is API change in 4.4 development cycle. where only 4.4 needs to be updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fiixed

@pliurh
Copy link
Contributor Author

pliurh commented Nov 12, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 12, 2019
@openshift-ci-robot
Copy link
Contributor

@pliurh: This pull request references Bugzilla bug 1770709, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zshi-redhat
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2019
@openshift-merge-robot openshift-merge-robot merged commit 7bd1324 into openshift:master Nov 12, 2019
@openshift-ci-robot
Copy link
Contributor

@pliurh: All pull requests linked via external trackers have merged. Bugzilla bug 1770709 has been moved to the MODIFIED state.

In response to this:

BUG 1770709: Use "preserveUnknownFields: false" for the CRD

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zshi-redhat zshi-redhat zshi-redhat left review comments

@squeed squeed Awaiting requested review from squeed

Assignees

@zshi-redhat zshi-redhat

Labels
bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pliurh @openshift-ci-robot @zshi-redhat @openshift-merge-robot