Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1770668: Optimize SrivoNetwork CR update logic #142

Merged
merged 2 commits into from Feb 3, 2020

Conversation

pliurh
Copy link
Contributor

@pliurh pliurh commented Dec 27, 2019

According to kubernetes-sigs/controller-runtime#675, cross namespace owner reference is disallowed by Kubernetes. In this PR, we use the finalizer for the garbage collection.

@openshift-ci-robot
Copy link
Contributor

@pliurh: This pull request references Bugzilla bug 1770668, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

BUG 1770668: Optimize SrivoNetwork CR update logic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 27, 2019
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 27, 2019
@pliurh pliurh changed the title BUG 1770668: Optimize SrivoNetwork CR update logic Optimize SrivoNetwork CR update logic Dec 27, 2019
@openshift-ci-robot
Copy link
Contributor

@pliurh: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Optimize SrivoNetwork CR update logic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 27, 2019
@pliurh pliurh changed the title Optimize SrivoNetwork CR update logic Bug 1770668: Optimize SrivoNetwork CR update logic Dec 30, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 30, 2019
@openshift-ci-robot
Copy link
Contributor

@pliurh: This pull request references Bugzilla bug 1770668, which is valid. The bug has been moved to the POST state.

In response to this:

Bug 1770668: Optimize SrivoNetwork CR update logic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pliurh
Copy link
Contributor Author

pliurh commented Dec 30, 2019

/test e2e-aws

@zshi-redhat
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2020
@openshift-merge-robot openshift-merge-robot merged commit 6a04c92 into openshift:master Feb 3, 2020
@openshift-ci-robot
Copy link
Contributor

@pliurh: All pull requests linked via external trackers have merged. Bugzilla bug 1770668 has been moved to the MODIFIED state.

In response to this:

Bug 1770668: Optimize SrivoNetwork CR update logic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pliurh
Copy link
Contributor Author

pliurh commented Feb 28, 2020

/cherrypick release-4.3

@openshift-cherrypick-robot

@pliurh: new pull request created: #160

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pliurh added a commit to pliurh/sriov-network-operator-1 that referenced this pull request Jun 28, 2021
Pass CLUSTER_TYPE to sriov operator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants