BUG 1867529: mellanox plugin - fix resetting unsupported NICs #323
Conversation
openshift-ci-robot
added
the
bugzilla/severity-high
|
@zshi-redhat: This pull request references Bugzilla bug 1867529, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
openshift-ci-robot
added
the
approved
|
@zshi-redhat: GitHub didn't allow me to request PR reviews from the following users: Mmduh-483. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
zshi-redhat
changed the title
|
@zshi-redhat: GitHub didn't allow me to request PR reviews from the following users: adrianchiris, moshe010. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@zshi-redhat Did you test the fix with mellanox nic? |
yes |
|
@pliurh this is likely the issue you hit that switchdev config be reverted automatically. |
|
/lgtm |
|
@Mmduh-483: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
looks good to me. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Mmduh-483, pliurh, zshi-redhat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@zshi-redhat: All pull requests linked via external trackers have merged: openshift/sriov-network-operator#323. Bugzilla bug 1867529 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix drain logic after node reboot
No description provided.