Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1870915: Enable sriov webhook to access replica rbac resources #326

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

zshi-redhat
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Aug 21, 2020
@openshift-ci-robot
Copy link
Contributor

@zshi-redhat: This pull request references Bugzilla bug 1846333, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1846333: Enable sriov webhook to access replica rbac resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 21, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2020
@pliurh
Copy link
Contributor

pliurh commented Aug 21, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pliurh, zshi-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2020
@zshi-redhat zshi-redhat changed the title Bug 1846333: Enable sriov webhook to access replica rbac resources Enable sriov webhook to access replica rbac resources Aug 21, 2020
@openshift-ci-robot
Copy link
Contributor

@zshi-redhat: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Enable sriov webhook to access replica rbac resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 21, 2020
@zshi-redhat zshi-redhat added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 21, 2020
@zshi-redhat zshi-redhat changed the title Enable sriov webhook to access replica rbac resources Bug 1846333: Enable sriov webhook to access replica rbac resources Aug 21, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 21, 2020
@openshift-ci-robot
Copy link
Contributor

@zshi-redhat: This pull request references Bugzilla bug 1846333, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1846333: Enable sriov webhook to access replica rbac resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zshi-redhat zshi-redhat added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 21, 2020
@zshi-redhat zshi-redhat changed the title Bug 1846333: Enable sriov webhook to access replica rbac resources Bug 1870915: Enable sriov webhook to access replica rbac resources Aug 21, 2020
@openshift-ci-robot
Copy link
Contributor

@zshi-redhat: This pull request references Bugzilla bug 1870915, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1870915: Enable sriov webhook to access replica rbac resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zshi-redhat
Copy link
Contributor Author

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit d433801 into openshift:master Aug 21, 2020
@openshift-ci-robot
Copy link
Contributor

@zshi-redhat: All pull requests linked via external trackers have merged: openshift/sriov-network-operator#326. Bugzilla bug 1870915 has been moved to the MODIFIED state.

In response to this:

Bug 1870915: Enable sriov webhook to access replica rbac resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SchSeba pushed a commit to SchSeba/sriov-network-operator that referenced this pull request Jul 28, 2022
The Intel series of E810 cards with a 1591 PF ID is added to the supported card listing

- Update docs with newly supported hardware
- Update supported device ids in config map
SchSeba pushed a commit to SchSeba/sriov-network-operator that referenced this pull request Aug 24, 2022
The Intel series of E810 cards with a 1591 PF ID is added to the supported card listing

- Update docs with newly supported hardware
- Update supported device ids in config map
pacevedom pushed a commit to pacevedom/sriov-network-operator that referenced this pull request Sep 21, 2022
The Intel series of E810 cards with a 1591 PF ID is added to the supported card listing

- Update docs with newly supported hardware
- Update supported device ids in config map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants