Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1878588: Add image reference for sriov-operator-must-gather #337

Merged
merged 1 commit into from Sep 14, 2020

Conversation

zshi-redhat
Copy link
Contributor

No description provided.

@zshi-redhat zshi-redhat changed the title Add image reference for sriov-network-must-gather Add image reference for sriov-operator-must-gather Sep 3, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2020
@zshi-redhat
Copy link
Contributor Author

@sosiouxme I'm adding a must-gather image reference in the csv manifests for this OLM managed Operator (SR-IOV). The image will not be used in the operator, it only serves as a reference for user to get the exact must-gather image link. Would you please help to check if this is the right approach for adding a must-gather image link?

The ocp-build-auto for sriov-network-must-gather is located at: https://github.com/openshift/ocp-build-data/blob/openshift-4.6/images/sriov-network-must-gather.yaml

@sosiouxme
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sosiouxme, zshi-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zshi-redhat zshi-redhat changed the title Add image reference for sriov-operator-must-gather Bug 1878588: Add image reference for sriov-operator-must-gather Sep 14, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 14, 2020
@openshift-ci-robot
Copy link
Contributor

@zshi-redhat: This pull request references Bugzilla bug 1878588, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1878588: Add image reference for sriov-operator-must-gather

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 14, 2020
@openshift-merge-robot openshift-merge-robot merged commit f85a3c1 into openshift:master Sep 14, 2020
@openshift-ci-robot
Copy link
Contributor

@zshi-redhat: All pull requests linked via external trackers have merged:

Bugzilla bug 1878588 has been moved to the MODIFIED state.

In response to this:

Bug 1878588: Add image reference for sriov-operator-must-gather

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants