Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1949202: Add metadata for ppc64le #491

Merged
merged 1 commit into from Apr 14, 2021
Merged

Bug 1949202: Add metadata for ppc64le #491

merged 1 commit into from Apr 14, 2021

Conversation

manojnkumar
Copy link
Contributor

Add metadata to indicate availability of sriov-network-operator on the ppc64le architecture.

Copy link
Contributor

@zshi-redhat zshi-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manojnkumar thanks for the PR!
sriov operator has an upstream project, would you mind sending the patch there, then we will backport to downstream once merged upstream.

btw, is this required for 4.8 FF?

@@ -371,6 +371,8 @@ spec:
labels:
olm-owner-enterprise-app: sriov-network-operator
olm-status-descriptors: sriov-network-operator.v4.8.0
operatorframework.io/arch.amd64: supported
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several operands managed by SR-IOV Operator, do you think we need to label them with the same tags?(I'm not very famiilar with how multi-arch works, any reference would be helpful here).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several operands managed by SR-IOV Operator, do you think we need to label them with the same tags?(I'm not very famiilar with how multi-arch works, any reference would be helpful here).

It is only required for the operator, and not all the operands.

@manojnkumar
Copy link
Contributor Author

@manojnkumar thanks for the PR!
sriov operator has an upstream project, would you mind sending the patch there, then we will backport to downstream once merged upstream.

btw, is this required for 4.8 FF?

@zshi-redhat : I do not see a 4.8 directory upstream? Should I be creating that? Not required for 4.8 FF, afaik.

@zshi-redhat
Copy link
Contributor

@manojnkumar thanks for the PR!
sriov operator has an upstream project, would you mind sending the patch there, then we will backport to downstream once merged upstream.
btw, is this required for 4.8 FF?

@zshi-redhat : I do not see a 4.8 directory upstream? Should I be creating that? Not required for 4.8 FF, afaik.

Looking at the upstream project, I think we had stopped updating the openshfit manifest there. My bad, we should not be proposing a PR to upstream.

@zshi-redhat
Copy link
Contributor

zshi-redhat commented Apr 12, 2021

@manojnkumar what's the implication or making this change?
I'm not ware of any sriov function testing on ppc64le, how it is verified?

@manojnkumar
Copy link
Contributor Author

@manojnkumar what's the implication or making this change?
I'm not ware of any sriov function testing on ppc64le or amd64, how it is verified?

The implication is that the operator becomes available in the UI (operatorhub).
The validation on ppc64le is done downstream.

@zshi-redhat
Copy link
Contributor

@manojnkumar what's the implication or making this change?
I'm not ware of any sriov function testing on ppc64le or amd64, how it is verified?

The implication is that the operator becomes available in the UI (operatorhub).
The validation on ppc64le is done downstream.

Does the validation contain testing on actual sriov hardware? or does it only validate the deployment of this operator?

@manojnkumar
Copy link
Contributor Author

@manojnkumar what's the implication or making this change?
I'm not ware of any sriov function testing on ppc64le or amd64, how it is verified?

The implication is that the operator becomes available in the UI (operatorhub).
The validation on ppc64le is done downstream.

Does the validation contain testing on actual sriov hardware? or does it only validate the deployment of this operator?

Yes, on actual sriov hardware (Mellanox ConnectX family).

@zshi-redhat
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2021
@zshi-redhat
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manojnkumar, zshi-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zshi-redhat
Copy link
Contributor

@manojnkumar It is required to have a linked BZ for this PR to merge since it has passed 4.8 feature freeze date.
Do you have the bugzilla already created?

@manojnkumar manojnkumar changed the title Add metadata for ppc64le Bug 1949202: Add metadata for ppc64le Apr 13, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Apr 13, 2021
@openshift-ci-robot
Copy link
Contributor

@manojnkumar: This pull request references Bugzilla bug 1949202, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1949202: Add metadata for ppc64le

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 13, 2021
@manojnkumar
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@manojnkumar: This pull request references Bugzilla bug 1949202, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@manojnkumar
Copy link
Contributor Author

@manojnkumar It is required to have a linked BZ for this PR to merge since it has passed 4.8 feature freeze date.
Do you have the bugzilla already created?

Added the reference. Waiting for the target to be set to 4.8.0.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Bugzilla bug 1949202, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zshi-redhat
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 14, 2021
@openshift-ci-robot
Copy link
Contributor

@zshi-redhat: This pull request references Bugzilla bug 1949202, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit e5e6a45 into openshift:master Apr 14, 2021
@openshift-ci-robot
Copy link
Contributor

@manojnkumar: All pull requests linked via external trackers have merged:

Bugzilla bug 1949202 has been moved to the MODIFIED state.

In response to this:

Bug 1949202: Add metadata for ppc64le

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@yselkowitz yselkowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these supposed to be under manifest.labels, not spec.labels?

bn222 pushed a commit to bn222/sriov-network-operator that referenced this pull request Sep 4, 2023
Remove use of ioutil deprecated functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants