New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1949202: Add metadata for ppc64le #491
Bug 1949202: Add metadata for ppc64le #491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manojnkumar thanks for the PR!
sriov operator has an upstream project, would you mind sending the patch there, then we will backport to downstream once merged upstream.
btw, is this required for 4.8 FF?
@@ -371,6 +371,8 @@ spec: | |||
labels: | |||
olm-owner-enterprise-app: sriov-network-operator | |||
olm-status-descriptors: sriov-network-operator.v4.8.0 | |||
operatorframework.io/arch.amd64: supported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several operands managed by SR-IOV Operator, do you think we need to label them with the same tags?(I'm not very famiilar with how multi-arch works, any reference would be helpful here).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several operands managed by SR-IOV Operator, do you think we need to label them with the same tags?(I'm not very famiilar with how multi-arch works, any reference would be helpful here).
It is only required for the operator, and not all the operands.
@zshi-redhat : I do not see a 4.8 directory upstream? Should I be creating that? Not required for 4.8 FF, afaik. |
Looking at the upstream project, I think we had stopped updating the openshfit manifest there. My bad, we should not be proposing a PR to upstream. |
@manojnkumar what's the implication or making this change? |
The implication is that the operator becomes available in the UI (operatorhub). |
Does the validation contain testing on actual sriov hardware? or does it only validate the deployment of this operator? |
Yes, on actual sriov hardware (Mellanox ConnectX family). |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manojnkumar, zshi-redhat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@manojnkumar It is required to have a linked BZ for this PR to merge since it has passed 4.8 feature freeze date. |
@manojnkumar: This pull request references Bugzilla bug 1949202, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@manojnkumar: This pull request references Bugzilla bug 1949202, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Added the reference. Waiting for the target to be set to 4.8.0. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 1949202, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@zshi-redhat: This pull request references Bugzilla bug 1949202, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@manojnkumar: All pull requests linked via external trackers have merged: Bugzilla bug 1949202 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't these supposed to be under manifest.labels, not spec.labels?
Remove use of ioutil deprecated functions
Add metadata to indicate availability of sriov-network-operator on the ppc64le architecture.