Bug 2060322: Add RBAC for 'infrastructures' to operator bundle @pliurh @bn222 #639

bn222 · 2022-03-08T09:36:23Z

No description provided.

openshift-ci · 2022-03-08T09:36:25Z

@bn222: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Add RBAC for 'infrastructures' to operator bundle @pliurh @bn222

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-03-08T09:37:50Z

@bn222: This pull request references Bugzilla bug 2060322, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead
expected Bugzilla bug 2060322 to depend on a bug targeting a release in 4.11.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2060322: Add RBAC for 'infrastructures' to operator bundle @pliurh @bn222

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bn222 · 2022-03-09T09:43:06Z

/bugzilla refresh

openshift-ci · 2022-03-09T09:43:09Z

@bn222: This pull request references Bugzilla bug 2060322, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead
expected Bugzilla bug 2060322 to depend on a bug targeting a release in 4.11.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bn222 · 2022-03-09T09:44:17Z

/bugzilla refresh

openshift-ci · 2022-03-09T09:44:20Z

@bn222: This pull request references Bugzilla bug 2060322, which is invalid:

expected Bugzilla bug 2060322 to depend on a bug targeting a release in 4.11.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bn222 · 2022-03-09T10:08:52Z

/bugzilla refresh

openshift-ci · 2022-03-09T10:08:59Z

@bn222: This pull request references Bugzilla bug 2060322, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2062151 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Bugzilla bug 2062151 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bn222 · 2022-03-09T10:52:19Z

@zshi-redhat

pliurh · 2022-03-18T13:34:03Z

manifests/4.10/supported-nic-ids_v1_configmap.yaml

@@ -22,8 +22,6 @@ data:
  Nvidia_mlx5_ConnectX-5_Ex: 15b3 1019 101a
  Nvidia_mlx5_ConnectX-6: 15b3 101b 101c
  Nvidia_mlx5_ConnectX-6_Dx: 15b3 101d 101e
-  Nvidia_mlx5_ConnectX-6_Lx: 15b3 101f 101e


do we want to remove these NICs from the supported list?

hm thanks for catching this. That was not the intention.

This happens when I run make bundle.

The device Nvidia_mlx5_ConnectX-6_Lx is missing from config/manifests/bases/sriov-network-operator_configmap.yaml.

It is not clear to me if it should be added to that yaml file, or removed by make bundle.

We maintain different support nic list between u/s and d/s. So we shall update make bundle to ignore this file. For this PR, I think you can just remove the change to this file.

pliurh · 2022-04-06T09:13:51Z

/lgtm

fabrizio8

LGTM

SchSeba · 2022-04-26T15:40:36Z

/label backport-risk-assessed

openshift-bot · 2022-05-11T05:49:49Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

SchSeba · 2022-05-12T11:37:32Z

/lgtm
/approve

openshift-ci · 2022-05-12T11:38:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bn222, fabrizio8, pliurh, SchSeba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [SchSeba,bn222,fabrizio8,pliurh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bn222 · 2022-05-25T07:47:57Z

/label cherry-pick-approved

openshift-ci · 2022-05-25T07:48:04Z

@bn222: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zhaozhanqi · 2022-05-25T09:30:58Z

/label cherry-pick-approved

openshift-ci · 2022-05-25T10:47:12Z

@bn222: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-05-25T10:49:14Z

@bn222: All pull requests linked via external trackers have merged:

openshift/sriov-network-operator#639

Bugzilla bug 2060322 has been moved to the MODIFIED state.

In response to this:

Bug 2060322: Add RBAC for 'infrastructures' to operator bundle @pliurh @bn222

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bn222 changed the title ~~Add RBAC for 'infrastructures' to operator bundle @pliurh @bn222~~ Bug 2060322: Add RBAC for 'infrastructures' to operator bundle @pliurh @bn222 Mar 8, 2022

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 8, 2022

openshift-ci bot requested review from fabrizio8 and pliurh March 8, 2022 09:39

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2022

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 9, 2022

openshift-ci bot requested a review from zhaozhanqi March 9, 2022 10:09

pliurh reviewed Mar 18, 2022

View reviewed changes

bn222 mentioned this pull request Mar 28, 2022

bug 2059292: Fix error when deploying sriov network operator #637

Closed

bn222 force-pushed the 2060322 branch from b3386a0 to a883b16 Compare April 6, 2022 09:11

openshift-ci bot assigned pliurh Apr 6, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2022

fabrizio8 approved these changes Apr 6, 2022

View reviewed changes

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 26, 2022

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2022

make manifests bundle

4e3e2ae

bn222 force-pushed the 2060322 branch from a883b16 to 4e3e2ae Compare May 12, 2022 10:25

openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 12, 2022

openshift-ci bot assigned SchSeba May 12, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2022

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 25, 2022

openshift-merge-robot merged commit 7a379aa into openshift:release-4.10 May 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 2060322: Add RBAC for 'infrastructures' to operator bundle @pliurh @bn222 #639

Bug 2060322: Add RBAC for 'infrastructures' to operator bundle @pliurh @bn222 #639

bn222 commented Mar 8, 2022

openshift-ci bot commented Mar 8, 2022

openshift-ci bot commented Mar 8, 2022

bn222 commented Mar 9, 2022

openshift-ci bot commented Mar 9, 2022

bn222 commented Mar 9, 2022

openshift-ci bot commented Mar 9, 2022

bn222 commented Mar 9, 2022

openshift-ci bot commented Mar 9, 2022

bn222 commented Mar 9, 2022

pliurh Mar 18, 2022

bn222 Mar 18, 2022

bn222 Mar 23, 2022

pliurh Apr 6, 2022

pliurh commented Apr 6, 2022

fabrizio8 left a comment

SchSeba commented Apr 26, 2022

openshift-bot commented May 11, 2022

SchSeba commented May 12, 2022

openshift-ci bot commented May 12, 2022

bn222 commented May 25, 2022

openshift-ci bot commented May 25, 2022

zhaozhanqi commented May 25, 2022

openshift-ci bot commented May 25, 2022

openshift-ci bot commented May 25, 2022

Bug 2060322: Add RBAC for 'infrastructures' to operator bundle @pliurh @bn222 #639

Bug 2060322: Add RBAC for 'infrastructures' to operator bundle @pliurh @bn222 #639

Conversation

bn222 commented Mar 8, 2022

openshift-ci bot commented Mar 8, 2022

openshift-ci bot commented Mar 8, 2022

bn222 commented Mar 9, 2022

openshift-ci bot commented Mar 9, 2022

bn222 commented Mar 9, 2022

openshift-ci bot commented Mar 9, 2022

bn222 commented Mar 9, 2022

openshift-ci bot commented Mar 9, 2022

bn222 commented Mar 9, 2022

pliurh Mar 18, 2022

Choose a reason for hiding this comment

bn222 Mar 18, 2022

Choose a reason for hiding this comment

bn222 Mar 23, 2022

Choose a reason for hiding this comment

pliurh Apr 6, 2022

Choose a reason for hiding this comment

pliurh commented Apr 6, 2022

fabrizio8 left a comment

Choose a reason for hiding this comment

SchSeba commented Apr 26, 2022

openshift-bot commented May 11, 2022

SchSeba commented May 12, 2022

openshift-ci bot commented May 12, 2022

bn222 commented May 25, 2022

openshift-ci bot commented May 25, 2022

zhaozhanqi commented May 25, 2022

openshift-ci bot commented May 25, 2022

openshift-ci bot commented May 25, 2022