Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.9] OCPBUGS-1021: Backport must-gather improvements #697

Merged
merged 1 commit into from Oct 24, 2022
Merged

[release-4.9] OCPBUGS-1021: Backport must-gather improvements #697

merged 1 commit into from Oct 24, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #687

/assign zeeke

@zeeke
Backport must-gather improvements
1e57f15 
Changes in this commit comes from
https://github.com/openshift/must-gather/ ,
as the collect script has been moved there
since release-4.11

Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 8, 2022
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-532 has been cloned as Jira Issue OCPBUGS-1021. Retitling PR to link against new bug.
/retitle [release-4.9] OCPBUGS-1021: Backport must-gather improvements

In response to this:

This is an automated cherry-pick of #687

/assign zeeke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.9] OCPBUGS-532: Backport must-gather improvements [release-4.9] OCPBUGS-1021: Backport must-gather improvements Sep 8, 2022
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 8, 2022
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-1021, which is invalid:

  • expected dependent Jira Issue OCPBUGS-532 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is an automated cherry-pick of #687

/assign zeeke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2022

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.9] OCPBUGS-1021: Backport must-gather improvements

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zeeke
Copy link
Contributor

zeeke commented Sep 19, 2022

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 19, 2022
@openshift-ci-robot
Copy link
Contributor

@zeeke: This pull request references Jira Issue OCPBUGS-1021, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.9.z) matches configured target version for branch (4.9.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-532 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-532 targets the "4.10.z" version, which is one of the valid target versions: 4.10.0, 4.10.z
  • bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zeeke
Copy link
Contributor

zeeke commented Sep 26, 2022 •
edited

/cc @zshi-redhat
/cc @zhaozhanqi
/cc @bn222

Please, take a look at this backport. It is about bringing to release-4.10 sriov must gather the improvements
we implemented in default must gather for 4.11+
https://github.com/openshift/must-gather/blob/master/collection-scripts/gather_sriov

@bn222
Copy link
Contributor

bn222 commented Sep 27, 2022 •
edited

/lgtm

@bn222
Copy link
Contributor

bn222 commented Sep 27, 2022

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 27, 2022
@zhaozhanqi
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 27, 2022
@zhaozhanqi
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 27, 2022
@zeeke
Copy link
Contributor

zeeke commented Sep 27, 2022

/cc zshi-redhat
/cc dougbtv
/cc s1061123

Please, can you help moving forward this backport?

@bn222
Copy link
Contributor

bn222 commented Sep 28, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2022
@zeeke
Copy link
Contributor

zeeke commented Oct 10, 2022

/assign @zshi-redhat

Please, can you help approving this backport?

@zeeke
Copy link
Contributor

zeeke commented Oct 20, 2022

@s1061123, @bn222 can you please have a look at this backport?

need approved label

@bn222
Copy link
Contributor

bn222 commented Oct 24, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bn222, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 538efba into openshift:release-4.9 Oct 24, 2022
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-1021 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #687

/assign zeeke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgoncalves
Copy link
Contributor

/cherry-pick release-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 26, 2022
Merged
@openshift-cherrypick-robot
Copy link
Author

@cgoncalves: new pull request created: #713

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbtv dougbtv Awaiting requested review from dougbtv

@zshi-redhat zshi-redhat Awaiting requested review from zshi-redhat

@bn222 bn222 Awaiting requested review from bn222

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

@s1061123 s1061123 Awaiting requested review from s1061123

Assignees

@zeeke zeeke

@zshi-redhat zshi-redhat

@bn222 bn222

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@openshift-cherrypick-robot @openshift-ci-robot @zeeke @bn222 @zhaozhanqi @cgoncalves @zshi-redhat @openshift-merge-robot